Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to upgrade the project to .NET 10.0 and modernize its NuGet package management through centralization. However, the PR contains several critical issues that will prevent it from working correctly.
Key intended changes:
- Upgrade target framework to .NET 10.0 across all projects and CI/CD workflows
- Centralize NuGet package version management using Directory.Packages.props
- Bump version to 2.0.0 and add symbol package publishing support
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/AltaSoft.ChoiceGenerator.Tests/AltaSoft.ChoiceGenerator.Tests.csproj | Updated target framework to net10.0 and removed explicit package versions |
| tests/AltaSoft.Choice.Generator.SnapshotTests/AltaSoft.Choice.Generator.SnapshotTests.csproj | Updated target framework to net10.0, removed explicit package versions, contains duplicate project reference |
| src/AltaSoft.Choice/AltaSoft.Choice.csproj | File has critical encoding corruption making it unreadable |
| src/AltaSoft.Choice.Generator/AltaSoft.Choice.Generator.csproj | Removed explicit package versions to use centralized management |
| Directory.Packages.props | Introduced centralized package version management with multiple non-existent package versions |
| Directory.Build.props | Added net10.0 to default target frameworks and bumped version to 2.0.0 |
| AltaSoft.ChoiceGenerator.sln | Updated Visual Studio version reference (with formatting issue) and added Directory.Packages.props |
| .github/workflows/publish_nuget.yml | Added .NET 10.0.x SDK setup and symbol package publishing |
| .github/workflows/dotnet.yml | Added .NET 10.0.x SDK setup |
| .github/workflows/build_nuget_dont_publish.yml | Added .NET 10.0.x SDK setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/AltaSoft.Choice.Generator.SnapshotTests/AltaSoft.Choice.Generator.SnapshotTests.csproj
Outdated
Show resolved
Hide resolved
…Generator.SnapshotTests.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…oice into feature/net10Updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to the project, focusing on upgrading to .NET 10.0, centralizing and simplifying NuGet package management, and improving the NuGet publishing workflow. The changes also include a major version bump to 2.0.0, reflecting these significant updates.
.NET and Visual Studio Upgrades:
.github/workflows/build_nuget_dont_publish.yml,.github/workflows/dotnet.yml,.github/workflows/publish_nuget.yml,Directory.Build.props, test project files) and updated the solution file to Visual Studio 18.1. [1] [2] [3] [4] [5] [6] [7] [8]Directory.Build.propsto includenet10.0.NuGet Package Management Improvements:
Directory.Packages.propsand removing explicit version numbers from individual project files. [1] [2] [3] [4]ManagePackageVersionsCentrallyproperty.NuGet Publishing Workflow Enhancements:
.snupkg), facilitating better debugging support.Versioning:
Directory.Build.propsto reflect breaking and significant changes.Miscellaneous:
Directory.Packages.propsto the solution file for improved management of solution items.