Skip to content

Updated to dotnet 10#10

Merged
temonk merged 6 commits intomainfrom
feature/net10Updates
Jan 12, 2026
Merged

Updated to dotnet 10#10
temonk merged 6 commits intomainfrom
feature/net10Updates

Conversation

@temonk
Copy link
Copy Markdown
Contributor

@temonk temonk commented Jan 5, 2026

This pull request introduces several important updates to the project, focusing on upgrading to .NET 10.0, centralizing and simplifying NuGet package management, and improving the NuGet publishing workflow. The changes also include a major version bump to 2.0.0, reflecting these significant updates.

.NET and Visual Studio Upgrades:

  • Added .NET 10.0 as a target framework across the solution, including in CI workflows (.github/workflows/build_nuget_dont_publish.yml, .github/workflows/dotnet.yml, .github/workflows/publish_nuget.yml, Directory.Build.props, test project files) and updated the solution file to Visual Studio 18.1. [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated the default target frameworks in Directory.Build.props to include net10.0.

NuGet Package Management Improvements:

  • Centralized NuGet package version management by introducing Directory.Packages.props and removing explicit version numbers from individual project files. [1] [2] [3] [4]
  • Enabled central package version management via the ManagePackageVersionsCentrally property.

NuGet Publishing Workflow Enhancements:

  • Updated the NuGet publishing workflow to also publish symbol packages (.snupkg), facilitating better debugging support.

Versioning:

  • Bumped the project version to 2.0.0 in Directory.Build.props to reflect breaking and significant changes.

Miscellaneous:

  • Added Directory.Packages.props to the solution file for improved management of solution items.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to upgrade the project to .NET 10.0 and modernize its NuGet package management through centralization. However, the PR contains several critical issues that will prevent it from working correctly.

Key intended changes:

  • Upgrade target framework to .NET 10.0 across all projects and CI/CD workflows
  • Centralize NuGet package version management using Directory.Packages.props
  • Bump version to 2.0.0 and add symbol package publishing support

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/AltaSoft.ChoiceGenerator.Tests/AltaSoft.ChoiceGenerator.Tests.csproj Updated target framework to net10.0 and removed explicit package versions
tests/AltaSoft.Choice.Generator.SnapshotTests/AltaSoft.Choice.Generator.SnapshotTests.csproj Updated target framework to net10.0, removed explicit package versions, contains duplicate project reference
src/AltaSoft.Choice/AltaSoft.Choice.csproj File has critical encoding corruption making it unreadable
src/AltaSoft.Choice.Generator/AltaSoft.Choice.Generator.csproj Removed explicit package versions to use centralized management
Directory.Packages.props Introduced centralized package version management with multiple non-existent package versions
Directory.Build.props Added net10.0 to default target frameworks and bumped version to 2.0.0
AltaSoft.ChoiceGenerator.sln Updated Visual Studio version reference (with formatting issue) and added Directory.Packages.props
.github/workflows/publish_nuget.yml Added .NET 10.0.x SDK setup and symbol package publishing
.github/workflows/dotnet.yml Added .NET 10.0.x SDK setup
.github/workflows/build_nuget_dont_publish.yml Added .NET 10.0.x SDK setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

temonk and others added 5 commits January 5, 2026 14:55
…Generator.SnapshotTests.csproj

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@temonk temonk merged commit 2f3fddc into main Jan 12, 2026
1 check passed
@temonk temonk deleted the feature/net10Updates branch January 12, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants