[82] Preserve current health across relog like C++#85
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2a7b49d4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa4c8370a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a42d4ee91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
alseif0x
deleted the
82-follow-up-preserve-current-health-across-relog-like-c++
branch
1 participant
Closes #82
Summary
characters.healthas current health and restore it after max-health recalculation, clamped like C++Player::LoadFromDB.Player::SaveToDB.Codex reviewer verdictbefore merge/issue close.C++ anchors
/home/server/woltk-trinity-legacy/src/server/game/Entities/Player/Player.cppPlayer::LoadFromDB: saved health zero marks corpse, thenSetHealth(min(savedHealth, GetMaxHealth()))after stat recalculation./home/server/woltk-trinity-legacy/src/server/game/Entities/Player/Player.cppPlayer::SaveToDB: writesGetHealth()immediately before power fields./home/server/woltk-trinity-legacy/src/server/game/Entities/Player/Player.cppPlayer::ResurrectPlayerand/home/server/woltk-trinity-legacy/src/server/game/Handlers/MiscHandler.cppHandleReclaimCorpse: reclaim usesResurrectPlayer(0.5f)outside battlegrounds.Validation
cargo fmt --checkPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world --lib(2630 passed)PROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world logout_save_snapshot --libPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world reclaim_corpse_dead_ghost_resurrects_and_clears_ghost_like_cpp --libPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world runtime_damage_zero_health_marks_canonical_player_dead_like_cpp --libPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-servergit diff --checkrustycore-world: Luqedos damaged from6310to2978, logout/re-enter preserved2978; DB confirmedcharacters.health = 2978.Codex reviewer verdict.