[02.1] Fix SpellPower review issues from PR #78#83
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ca70a2273
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
rustycore/crates/wow-world/src/handlers/spell.rs
Lines 397 to 400 in cae2a4e
Mirror power spends into session snapshots
When a client cast spends power here, only the canonical Player is mutated. Paths such as start_player_attack_like_cpp call ensure_canonical_world_map_for_current_player_like_cpp, which rebuilds the canonical player from session state that does not carry powers, so casting a spell and then starting an attack/entering another resync path can replace the spent value with a fresh default before logout save. Please preserve the updated powers during canonical resync or mirror them into the session snapshot.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0ea708651
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
alseif0x
deleted the
79-021-follow-up-fix-spellpower-review-issues-from-pr-78
branch
1 participant
Closes #79
Summary
RUSTYCORE_SPELL_POWER_TRACE.Validation
cargo fmt --all -- --checkgit diff --checkPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world power --libPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-world --libPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo test -p wow-data player_stats --libPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo check -p world-serverPROTOC=/home/cdmonio/.local/protoc/bin/protoc cargo build -p world-server --releaseFollow-ups Split Out
Do not merge/close until CI is green and the configured Codex reviewer has given its verdict, with all actionable review comments handled or explicitly deferred.