Skip to content

ucm: clean up data types #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
floppym wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ucm: clean up data types #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ucm/ucm_exec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ static int parse_args(char ***argv, int argc, const char *cmd)
*/
int uc_mgr_exec(const char *prog)
{
pid_t p, f;
pid_t p;
int err = 0, status;
char bin[PATH_MAX];
struct sigaction sa;
Expand Down Expand Up @@ -239,7 +239,7 @@ int uc_mgr_exec(const char *prog)
}

if (p == 0) {
f = open("/dev/null", O_RDWR);
int f = open("/dev/null", O_RDWR);
if (f == -1) {
snd_error(UCM, "pid %d cannot open /dev/null for redirect %s -- %s",
getpid(), prog, strerror(errno));
Expand All @@ -261,7 +261,7 @@ int uc_mgr_exec(const char *prog)
closefrom(3);
#else
{
pid_t maxfd = sysconf(_SC_OPEN_MAX);
long maxfd = sysconf(_SC_OPEN_MAX);
for (f = 3; f < maxfd; f++)
close(f);
}
Expand All @@ -287,8 +287,8 @@ int uc_mgr_exec(const char *prog)
setpgid(p, p);

while (1) {
f = waitpid(p, &status, 0);
if (f == -1) {
pid_t r = waitpid(p, &status, 0);
if (r == -1) {
if (errno == EAGAIN)
continue;
err = -errno;
Expand Down
Loading