Fix: (--check-pandoc-no-wrap-option) Handle option has been removed#69
Open
aavanian wants to merge 2 commits intoalphapapa:masterfrom
Open
Fix: (--check-pandoc-no-wrap-option) Handle option has been removed#69aavanian wants to merge 2 commits intoalphapapa:masterfrom
aavanian wants to merge 2 commits intoalphapapa:masterfrom
Conversation
alphapapa
requested changes
Jan 25, 2024
Owner
alphapapa
left a comment
alphapapa
left a comment
There was a problem hiding this comment.
Thanks for reporting this bug and suggesting this patch. I'd suggest making these amendments, and then it can be merged.
Comment on lines
+199
to
+200
| (not (string-match "--no-wrap is deprecated" (buffer-string))) | ||
| (not (string-match "--no-wrap has been removed" (buffer-string)))) |
Owner
There was a problem hiding this comment.
This would be better written using a single regular expression matching both strings. The rx macro makes these easy to read and write.
As well, this would be a good opportunity to use string-match-p instead.
Author
There was a problem hiding this comment.
Done though not sure about your preference about line length and where to break it.
Author
|
Note on the last two actions: I issued this PR from my fork's master and it picked up a change that wasn't meant for this PR. Apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68