SPIKE implementing polling instead of Turbo for image processing checking [WHIT-3226]#11352
Draft
patrickpatrickpatrick wants to merge 4 commits intomainfrom
Draft
SPIKE implementing polling instead of Turbo for image processing checking [WHIT-3226]#11352patrickpatrickpatrick wants to merge 4 commits intomainfrom
patrickpatrickpatrick wants to merge 4 commits intomainfrom
Conversation
patrickpatrickpatrick
force-pushed
the
polling-not-turbo
branch
3 times, most recently
from
74dd38c to
4ab1485
Compare
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
changed the title
patrickpatrickpatrick
force-pushed
the
polling-not-turbo
branch
3 times, most recently
from
35a20e9 to
cd1be15
Compare
patrickpatrickpatrick
force-pushed
the
polling-not-turbo
branch
2 times, most recently
from
147d74c to
008d7a3
Compare
patrickpatrickpatrick
force-pushed
the
polling-not-turbo
branch
from
008d7a3 to
43bf394
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement polling to check if an image is processed, rather than asking the user to refresh the page to see a processed image.
Technical Details
edition_images#showImageProcessingCheckerImageProcessingCheckertoImageComponentImageProcessingCheckertoImageCropperinittostartinitthat runsstartif there is an image in theImageCroppercomponentWhy
Provides a more intuitive experience if users do not have to refresh the page to see uploaded images.
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.