Rename process_associations_before/after methods#11165
Draft
ChrisBAshton wants to merge 1 commit intomainfrom
Draft
Rename process_associations_before/after methods#11165ChrisBAshton wants to merge 1 commit intomainfrom
ChrisBAshton wants to merge 1 commit intomainfrom
Conversation
The original naming implied that the trait methods were called every time an edition were updated, when in fact these methods are only called when a new draft is created (not just 'on save' on a given edition). I think this rename makes the actual behaviour clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original naming implied that the trait methods were called every time an edition were updated, when in fact these methods are only called when a new draft is created (not just 'on save' on a given edition).
I think this rename makes the actual behaviour clearer.
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.