Use LocalDate for session start time calculation#36
Closed
alv-cor wants to merge 2 commits intoaload0:mainfrom
Closed
Use LocalDate for session start time calculation#36alv-cor wants to merge 2 commits intoaload0:mainfrom
alv-cor wants to merge 2 commits intoaload0:mainfrom
Conversation
Replaced System.currentTimeMillis() with LocalDate.now().atTime(...).atZone(...).toInstant().toEpochMilli() for more accurate session start time based on the routine's scheduled time and system time zone.
Member
|
The rest of the app still uses |
Contributor
Author
|
According to my tests, routines were not working correctly with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced System.currentTimeMillis() with LocalDate.now().atTime(...).atZone(...).toInstant().toEpochMilli() for more accurate session start time based on the routine's scheduled time and system time zone.