Skip to content

refactor: add more precise url definition provider - now takes directly to the url defintion line#23

Merged
almahdi404 merged 1 commit intoalmahdi404:mainfrom
WellingtonNico:main
Mar 23, 2026
Merged

refactor: add more precise url definition provider - now takes directly to the url defintion line#23
almahdi404 merged 1 commit intoalmahdi404:mainfrom
WellingtonNico:main

Conversation

@WellingtonNico
Copy link
Contributor

Hello again!

It's me, I implemented the url defintion and some other autocomplete functionalities, I hope you remember me.

I just made an improvement.

Before:

  • When user clicked url name, the user was taken to the file, but sometimes the file could be too big, and the user still needed to search for the url name inside the file.

Now:

  • When user clicks url name, the user is takes directly to the file but also the line of the definition, much better.

I hope you like it, I'm waiting for the update.

Peace..

@WellingtonNico
Copy link
Contributor Author

WellingtonNico commented Mar 23, 2026

But there is something I'd like to talk about with you, check this image:

image

I hope you can note the undeline in the first anchor, in that case, the ctrl+click to go to the url definition is not gonna work, because vscode is detecting it like it was a truly URL. Now check the second anchor, in that case vscode does not detect it as truly URL, so ctrl+click to url definition works normally.
This happens because in the second case I used href=' instead of href=", I think it would be better if in both cases vscode could behave like the second anchor, so definition provider could work always. What can we do for that?

@almahdi404
Copy link
Owner

I guess, you have to use double quotes inside, if you are using single quotes href='...'

@almahdi404 almahdi404 merged commit dba5c7b into almahdi404:main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants