Skip to content

Prevent IndexOutOfBoundsException for synthetic parameters in Kotlin suspend functions #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denysgaievskyi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent IndexOutOfBoundsException for synthetic parameters in Kotlin suspend functions #1231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions allure-junit5/src/main/java/io/qameta/allure/junit5/AllureJunit5.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.lang.reflect.Parameter;
import java.util.HashMap;
import java.util.Map;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.UUID;
Expand Down Expand Up @@ -62,15 +63,20 @@ public void interceptTestTemplateMethod(final Invocation<Void> invocation,
private void sendParameterEvent(final ReflectiveInvocationContext<Method> invocationContext,
final ExtensionContext extensionContext) {
final Parameter[] parameters = invocationContext.getExecutable().getParameters();
for (int i = 0; i < parameters.length; i++) {
final Parameter parameter = parameters[i];
final List<Object> arguments = invocationContext.getArguments();
int argumentIndex = 0;

for (final Parameter parameter : parameters) {
final Class<?> parameterType = parameter.getType();
// Skip default jupiter injectables as TestInfo, TestReporter and TempDirectory
if (parameterType.getCanonicalName().startsWith("org.junit.jupiter.api")) {

// Skip JUnit injectables AND synthetic parameters
if (parameterType.getCanonicalName().startsWith("org.junit.jupiter.api")
|| parameter.isSynthetic()
|| argumentIndex >= arguments.size()) {
continue;
}
final Object value = invocationContext.getArguments().get(i);

final Object value = arguments.get(argumentIndex++);
final Map<String, String> map = new HashMap<>();
map.put(ALLURE_PARAMETER, parameter.getName());
map.put(ALLURE_PARAMETER_VALUE_KEY, ObjectUtils.toString(value));
Expand Down
Loading