Skip to content

fix(ci): quote labeler keys containing colons#13

Merged
kzndotsh merged 1 commit intomainfrom
fix/labeler-yaml-keys
Mar 29, 2026
Merged

fix(ci): quote labeler keys containing colons#13
kzndotsh merged 1 commit intomainfrom
fix/labeler-yaml-keys

Conversation

@kzndotsh
Copy link
Copy Markdown
Contributor

@kzndotsh kzndotsh commented Mar 29, 2026

Summary

  • Quote label keys in .github/labeler.yml that contain colons (for example app: portal) so the file is valid YAML.
  • Preserve existing label matching patterns and behavior; this is a syntax-only correction.
  • Unblock Portal CI lint (pnpm check / ultracite check) which was failing on YAML parse errors.

Test plan

  • Run pnpm exec ultracite check .github/labeler.yml locally.
  • Verify Portal CI / Lint passes on this PR.
  • Confirm label automation still applies expected labels on changed files.

Made with Cursor

Summary by Sourcery

Bug Fixes:

  • Quote label keys with colons in .github/labeler.yml so the file is valid YAML and CI linting can parse it correctly.

Summary by cubic

Quote label keys containing colons in .github/labeler.yml to fix YAML parsing and stop lint failures in Portal CI (pnpm check / ultracite). Label behavior is unchanged; this is a syntax-only fix.

Written for commit c28ac0c. Summary will update on new commits.

YAML keys like app: portal were parsed as invalid mappings, causing ultracite lint to fail in Portal CI. Quote these keys so label matching remains unchanged while restoring valid YAML syntax.

Made-with: Cursor
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 29, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Quotes YAML mapping keys containing colons in .github/labeler.yml so the labeler config parses correctly while preserving existing label patterns and behavior.

Sequence diagram for CI linting of labeler configuration

sequenceDiagram
  actor Dev
  participant GitHub
  participant Portal_CI
  participant Lint_Job
  participant Ultracite
  participant Labeler_Config

  Dev->>GitHub: Open or update pull_request
  GitHub->>Portal_CI: Trigger Portal CI workflow
  Portal_CI->>Lint_Job: Start pnpm check
  Lint_Job->>Ultracite: Run ultracite check .github/labeler.yml
  Ultracite->>Labeler_Config: Parse labeler.yml (quoted keys with colons)
  Labeler_Config-->>Ultracite: YAML parsed successfully
  Ultracite-->>Lint_Job: Report success
  Lint_Job-->>Portal_CI: Lint job passes
  Portal_CI-->>GitHub: Report status success to PR
Loading

File-Level Changes

Change Details Files
Quote all labeler YAML keys that contain colons so they are treated as string keys rather than nested mappings.
  • Wrap label keys like app: portal, app: web, app: docs, app: tools, app: chat-web, app: bridge, service: irc, service: xmpp, service: network, and service: observability in double quotes
  • Keep all associated changed-files and any-glob-to-any-file patterns identical to the previous configuration to avoid behavior changes
  • Ensure the labeler configuration becomes valid YAML so CI linting and parsing succeed
.github/labeler.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the ci label Mar 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

📝 Walkthrough

Walkthrough

This pull request updates .github/labeler.yml by adding double quotes around specific label key declarations. The underlying file matching patterns, path globs, and labeling logic remain unchanged. This is a purely formatting adjustment to improve YAML consistency.

Changes

Cohort / File(s) Summary
GitHub Labeler Configuration
.github/labeler.yml
Quoted 10 label keys ("app: portal", "app: web", "app: docs", "app: tools", "app: chat-web", "app: bridge", "service: irc", "service: xmpp", "service: network", "service: observability") for YAML consistency. File matching rules and patterns unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description provides a clear summary, test plan, and context, but does not follow the repository's required template structure with sections like Changes, Type of Change, Testing, Checklist, and Related Issues. Consider reformatting the description to match the repository template with sections for Changes, Type of Change, Testing, Checklist, and Related Issues for consistency and future reference.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: quoting labeler keys that contain colons in the .github/labeler.yml file to fix YAML syntax issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/labeler-yaml-keys
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/labeler-yaml-keys

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c28ac0c.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML syntax fix is correct and addresses the parse errors by properly quoting label keys containing colons. The changes preserve existing label matching patterns and behavior while making the file valid YAML. No blocking issues found.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@kzndotsh kzndotsh added this pull request to the merge queue Mar 29, 2026
Merged via the queue into main with commit f3f48aa Mar 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant