fix parseFunctionNames() parsing only the first function name (issue #13) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psolaimani
changed the title
Current coverage is 35.78% (diff: 41.85%)@@ master #14 diff @@
==========================================
Files 10 11 +1
Lines 1001 1185 +184
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 339 424 +85
- Misses 662 761 +99
Partials 0 0
|
added 26 commits
July 7, 2016 13:51
- Run all test scripts in tests/ instead of just testthat (packages should be installed with "--install-tests" or NO tests will be run) - Look for example source in R-ex (packages should be installed with --example) - Invalid test cases are preserved for debugging purposes The test generation code appears to be generating a large number of invalid test cases (~ 90% invalid).
- Also run package examples via example() so that don't run / don't test is respected.
For some base packages there is a fair degree of tests generated over and over again that don't need to be validated each time.
Otherwise failed tests/examples can lead to corrupted capture files that never get removed.
Does not seem to be working. Will just set the current directory when running examples
The linux timeout tool will only send a TERM signal by default. Adding the --kill-after flag will ensure that the script is sent the KILL signal if it fails to exit cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed function now correctly handles different edge cases.
testr:::parseFunctionNames(c("stats::hello","stats:::why","stats:::",":::","world","abc::def::gh"))