updated UI #126
Open
updated UI #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for alloradocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: AJ Mannan <amannan@usc.edu>
Signed-off-by: AJ Mannan <amannan@usc.edu>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ( | ||
| <div | ||
| className="markdown-content" | ||
| dangerouslySetInnerHTML={{ __html: renderMarkdown(content) }} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 8 months ago
To fix the issue, the input to renderMarkdown must be sanitized to remove any potentially malicious content before it is processed and injected into the DOM. This can be achieved by using a library like DOMPurify to sanitize the HTML output generated by renderMarkdown.
Steps to implement the fix:
- Install the
dompurifylibrary to sanitize HTML content. - Import
DOMPurifyinto the file. - Use
DOMPurify.sanitizeto clean the HTML output fromrenderMarkdownbefore passing it todangerouslySetInnerHTML.
Suggested changeset
2
components/chatbutton1.js
| @@ -1,2 +1,3 @@ | ||
| import React, { useState, useRef, useEffect } from "react"; | ||
| import DOMPurify from "dompurify"; | ||
|
|
||
| @@ -34,2 +35,4 @@ | ||
|
|
||
| const sanitizedHtml = DOMPurify.sanitize(renderMarkdown(content)); | ||
|
|
||
| return ( | ||
| @@ -37,3 +40,3 @@ | ||
| className="markdown-content" | ||
| dangerouslySetInnerHTML={{ __html: renderMarkdown(content) }} | ||
| dangerouslySetInnerHTML={{ __html: sanitizedHtml }} | ||
| /> |
package.json
Outside changed files
| @@ -8,3 +8,4 @@ | ||
| "react-dom": "^18.3.1", | ||
| "react-katex": "^3.0.1" | ||
| "react-katex": "^3.0.1", | ||
| "dompurify": "^3.2.6" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| dompurify (npm) | 3.2.6 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Signed-off-by: AJ Mannan <amannan@usc.edu>
Signed-off-by: AJ Mannan <amannan@usc.edu>
Signed-off-by: AJ Mannan <amannan@usc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.