feat(secrets): Implement strict secret path validation#109
Merged
Conversation
Introduce a new validation mechanism for secret paths to ensure consistency, security, and predictability across the storage engine. All secret paths now undergo character set, length, and format checks before processing. Key changes: - Added 'validateSecretPath' in 'internal/secrets/usecase/validator.go' with rules for alphanumeric characters, hyphens, underscores, and slashes. - Enforced path constraints: 1-255 characters, no leading/trailing slashes, and no consecutive symbols (//, --, __). - Introduced 'ErrInvalidSecretPath' mapped to 'StatusUnprocessableEntity' (422) to align with the project's validation error standards. - Updated OpenAPI specification and product documentation to reflect the new naming requirements. - Adjusted existing tests and added a comprehensive test suite for path validation. Why: To prevent path-based injection vulnerabilities, ensure storage predictability, and maintain a clean, standardized secret namespace. Ref: Add Secret Path Validation track
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new validation mechanism for secret paths to ensure consistency, security, and predictability across the storage engine. All secret paths now undergo character set, length, and format checks before processing.
Key changes:
Why: To prevent path-based injection vulnerabilities, ensure storage predictability, and maintain a clean, standardized secret namespace.
Ref: Add Secret Path Validation track