Conversation
SourceHook and CDetour with KHook`SourceHook and CDetour with KHook
|
Are we still concerned about using STL on public interfaces? things will get weird with gcc vs clang extensions. |
That's a good point. I've mainly stripped every instances of the word That said, looking at the two interfaces affected Core & bridge are built as a package deal so we probably don't have to worry about diverging STL implems. Unless we want to preserve that flexibility in hot swapping core and bridge libs, in which case I can just bring |
59869ff to
a6c3aea
Compare
48b5f88 to
56f811c
Compare
In the continuity of alliedmodders/metamod-source#223. This PR strips
SourceHookandCDetourfrom SourceMod.Marked as a Draft until I finish writing the x86 assembly for dhooks on windows, and I'd like to have some unofficial builds tested around first. Local testing looks good though!
Breaking changes
Benefits
Those breaking changes are definitively not ideal, and I went in working on this knowing full well the PR might die at the finish line.
In the PR's defense, I have worked on this x86_64 support project (MM:S, SM, KHook) on and off for nearly 2 years, and in that timespan nobody has offered something close to a working alternative. I believe this is as good as it will ever get..