Skip to content

Add support for Sentinel-2 L2A data from EarthDaily with harmonization options#552

Merged
favyen2 merged 16 commits intoallenai:masterfrom
robmarkcole:support-sentinel-2-l2a-eda
Mar 26, 2026
Merged

Add support for Sentinel-2 L2A data from EarthDaily with harmonization options#552
favyen2 merged 16 commits intoallenai:masterfrom
robmarkcole:support-sentinel-2-l2a-eda

Conversation

@robmarkcole
Copy link
Copy Markdown
Collaborator

@robmarkcole robmarkcole commented Mar 5, 2026

  • Introduced Sentinel2L2A class for accessing L2A data.
  • Updated documentation for earthdaily_Sentinel2L2A.md.
  • Added tests for harmonization of non-visual bands in test_earthdaily_sentinel2_l2a.py.
  • Enhanced existing EarthDaily data source to support new harmonization logic.
  • Addresses [Documentation] sentinel-2-c1-l2a appears incomplete #551 in docs

I'm inclined to remove sentinel-2-c1-l2a now I am aware of the missing data issue, any thoughts?

…n options

- Introduced `Sentinel2L2A` class for accessing L2A data.
- Updated documentation for `earthdaily_Sentinel2L2A.md`.
- Added tests for harmonization of non-visual bands in `test_earthdaily_sentinel2_l2a.py`.
- Enhanced existing EarthDaily data source to support new harmonization logic.
@robmarkcole robmarkcole changed the title [DRAFT] Add support for Sentinel-2 L2A data from EarthDaily with harmonization options Add support for Sentinel-2 L2A data from EarthDaily with harmonization options Mar 5, 2026
Copy link
Copy Markdown
Collaborator

@favyen2 favyen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the C1 L2A sounds fine to me if it is unlikely to be used due to the missing scenes.

Comment thread rslearn/data_sources/earthdaily.py Outdated
Comment thread rslearn/data_sources/earthdaily.py Outdated
@robmarkcole
Copy link
Copy Markdown
Collaborator Author

We (EDA) are discussing performing the outstanding processing of C1 L2A so lets keep it afterall

Copy link
Copy Markdown
Collaborator

@favyen2 favyen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just one minor comment

Comment thread rslearn/data_sources/earthdaily.py
@robmarkcole
Copy link
Copy Markdown
Collaborator Author

@favyen2 let me know if this is good now, thanks

@favyen2
Copy link
Copy Markdown
Collaborator

favyen2 commented Mar 26, 2026

This looks good but there are some lint/test errors.

@favyen2 favyen2 merged commit e19ebf8 into allenai:master Mar 26, 2026
3 checks passed
@robmarkcole robmarkcole deleted the support-sentinel-2-l2a-eda branch March 26, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants