[BUGFIX] Enhance EarthDaily Sentinel-2 support for scale/offset metadata and nodata handling#548
Merged
favyen2 merged 6 commits intoallenai:masterfrom Apr 1, 2026
Merged
Conversation
…odata handling - Updated asset_scale_offsets to include nodata values in EarthDailyItem. - Modified read_raster to preserve nodata pixels during scaling. - Added validation for float32 dtype requirement when apply_scale_offset is enabled. - Enhanced tests to cover nodata preservation and dtype validation.
# Conflicts: # docs/data_sources/earthdaily_Sentinel2.md # rslearn/data_sources/earthdaily.py # tests/unit/data_sources/test_earthdaily_scale_offset.py
robmarkcole
changed the title
favyen2
approved these changes
Mar 31, 2026
Collaborator
favyen2
left a comment
favyen2
left a comment
There was a problem hiding this comment.
looks good to me, one minor comment to simplify the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #547