Expand type-checking coverage#1688
Open
finbarrtimbers wants to merge 10 commits into
Open
Conversation
… Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Documentation Changes Detected📄
|
…ference. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a migration plan to replace HfArgumentParser with jsonargparse to improve type-checking across the codebase. It includes various type hint updates, refactors the tool_server.py to use CodeResponse models, and adjusts the return types of instruction-following validation functions. Review feedback highlights that the docstrings for validate_placeholders and verify_bullet_points need to be updated to reflect the new return types and parameter names to maintain consistency with the implementation.
…e Opus 4.7 <noreply@anthropic.com>
…match new bool return type. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…o-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…de Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.