Conversation
epwalsh
reviewed
Nov 20, 2025
Contributor
epwalsh
left a comment
epwalsh
left a comment
There was a problem hiding this comment.
Everything looks good now other than learning rate.
tyler-romero
force-pushed
the
dirkg/2B
branch
from
846b670 to
5a162db
Compare
baileykuehl
reviewed
Nov 21, 2025
| ), | ||
| ) | ||
| .with_callback( | ||
| "comet", |
Contributor
There was a problem hiding this comment.
Do we still need this even though we don't have comet anymore? Won't it always be enabled=False?
Contributor
There was a problem hiding this comment.
Yeah I agree we can drop it in configs going forwards
The exponential LR scheduler implementation and tests are already merged in src/olmo_core/optim/scheduler.py and src/test/optim/scheduler_test.py. These test scripts are personal tools for LR range finding and don't need to be in the main repo.
tyler-romero
force-pushed
the
dirkg/2B
branch
from
26c1e67 to
2a66498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.