Skip to content

DO-1802: Add Yamllinting, actionlinting and zizmor static analysis#103

Draft
AdamJHall wants to merge 8 commits intohotfix/DO-1765-Serverless-Deployment-Fixesfrom
feature/DO-1802-CI-for-workflows
Draft

DO-1802: Add Yamllinting, actionlinting and zizmor static analysis#103
AdamJHall wants to merge 8 commits intohotfix/DO-1765-Serverless-Deployment-Fixesfrom
feature/DO-1802-CI-for-workflows

Conversation

@AdamJHall
Copy link
Contributor

@AdamJHall AdamJHall commented Mar 18, 2026

Description of the proposed changes
This PR adds three checks to validate our workflows on each PR in: .github/workflows/ci.yml

  1. Yamllint - Checks for valid yaml and makes sure we follow a consistent standard
  2. actionlint - Checks for valid github action / workflow syntax
  3. zizmor - Performs static analysis and additional security checks to make sure the workflows will work

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned in our contribution guide.

Notes to reviewers

ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@github-advanced-security
Copy link

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@AdamJHall AdamJHall changed the title DO-1802: Add Yamllinting, actionlinting and zizmor static analysis to… DO-1802: Add Yamllinting, actionlinting and zizmor static analysis Mar 18, 2026
@AdamJHall AdamJHall marked this pull request as ready for review March 18, 2026 23:22
@AdamJHall AdamJHall requested a review from a team as a code owner March 18, 2026 23:22
@AdamJHall AdamJHall requested review from NgaNaNa, TheOrangePuff, aaronmedina-dev, crispy101 and hubertott and removed request for a team March 18, 2026 23:22
@AdamJHall AdamJHall marked this pull request as draft March 18, 2026 23:22
@AdamJHall
Copy link
Contributor Author

@AligentDevOps,

Leaving as a draft until hotfix/DO-1765-Serverless-Deployment-Fixes is merged as I stupidly based it off that branch and don't want to mess around with git :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant