DO-1802: Add Yamllinting, actionlinting and zizmor static analysis#103
Draft
AdamJHall wants to merge 8 commits intohotfix/DO-1765-Serverless-Deployment-Fixesfrom
Draft
DO-1802: Add Yamllinting, actionlinting and zizmor static analysis#103AdamJHall wants to merge 8 commits intohotfix/DO-1765-Serverless-Deployment-Fixesfrom
AdamJHall wants to merge 8 commits intohotfix/DO-1765-Serverless-Deployment-Fixesfrom
Conversation
… our github workflows
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
zizmor found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
Author
|
Leaving as a draft until hotfix/DO-1765-Serverless-Deployment-Fixes is merged as I stupidly based it off that branch and don't want to mess around with git :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR adds three checks to validate our workflows on each PR in:
.github/workflows/ci.ymlNotes to PR author
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback