MI-312: Add default aspect for S3 and DynamoDB#1630
Open
kai-nguyen-aligent wants to merge 4 commits intomainfrom
Open
MI-312: Add default aspect for S3 and DynamoDB#1630kai-nguyen-aligent wants to merge 4 commits intomainfrom
kai-nguyen-aligent wants to merge 4 commits intomainfrom
Conversation
…312-default-aspect-for-stateful-resources
kai-nguyen-aligent
requested review from
AdamJHall,
NgaNaNa,
TheOrangePuff and
aaronmedina-dev
and removed request for
NgaNaNa
AdamJHall
previously approved these changes
Mar 17, 2026
| case "MEDIUM": | ||
| return { | ||
| pointInTimeRecoverySpecification: { | ||
| pointInTimeRecoveryEnabled: true, |
Contributor
There was a problem hiding this comment.
Are there many INT use cases that require PITR? I would think that most of the things we store in dynamo wouldn't require it or could be rebuilt relatively easily without it?
PITR is relatively cheap ($0.228 per GB-month) so it doesn't matter too much, but it is an added cost and devs should be aware so we aren't storing too much in them with PITR enabled.
Contributor
Author
There was a problem hiding this comment.
Agree, Adam. I don't think INT has many use cases for this. I'll remove this setting.
Contributor
Author
There was a problem hiding this comment.
Hi @AdamJHall I have made some changes to this aspect:
- Removed
pointInTimeRecoveryEnabledconfiguration. - Added
billingModewith some thoughput configurations:
a.SHOTnow has provisioned thoughput with read/write capacity = 1 for optimal cost
b.MEDIUM&LONGhave on demand thoughput butMEDIUMhas a cap of 100 RCUs/WCUs for enough for realistic functional/integration testing in Staging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback