Skip to content

Fix crash when loading comments section of pretty much every post #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EthanArbuckle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash when loading comments section of pretty much every post #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions AlienBlue.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,15 @@
/* Begin PBXProject section */
29B97313FDCFA39411CA2CEA /* Project object */ = {
isa = PBXProject;
attributes = {
};
buildConfigurationList = C01FCF4E08A954540054247B /* Build configuration list for PBXProject "AlienBlue" */;
compatibilityVersion = "Xcode 3.1";
developmentRegion = English;
hasScannedForEncodings = 1;
knownRegions = (
en,
);
mainGroup = 29B97314FDCFA39411CA2CEA /* NeuReddit */;
projectDirPath = "";
projectRoot = "";
Expand Down Expand Up @@ -638,6 +644,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = AlienBlue_Prefix.pch;
INFOPLIST_FILE = "AlienBlue-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 6.0;
PRODUCT_NAME = AlienBlue;
};
name = Debug;
Expand All @@ -654,6 +661,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = AlienBlue_Prefix.pch;
INFOPLIST_FILE = "AlienBlue-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 6.0;
PRODUCT_NAME = AlienBlue;
};
name = Release;
Expand Down Expand Up @@ -686,6 +694,7 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = AlienBlue_Prefix.pch;
INFOPLIST_FILE = "AlienBlue-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 6.0;
PRODUCT_NAME = AlienBlue;
};
name = Distribution;
Expand Down
27 changes: 22 additions & 5 deletions Classes/CommentsTableViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,22 @@ - (NSMutableArray *) parseBodyForUndescribedLinks:(NSMutableDictionary *) commen
int link_counter = 0;
BOOL linksAvailable = TRUE;
// NSLog(@"Body Text: %@",body);
while (linksAvailable) {
while (linksAvailable) {

//no crashes here, move it along
if ([body rangeOfString:@"http://" options:NSCaseInsensitiveSearch range:NSMakeRange (pos, bodyLength - pos)].location == NSNotFound)
break;

start_link_pos = [body rangeOfString:@"http://" options:NSCaseInsensitiveSearch range:NSMakeRange (pos, bodyLength - pos)].location;
end_link_pos = [body rangeOfString:@" " options:NSCaseInsensitiveSearch range:NSMakeRange (start_link_pos, bodyLength - start_link_pos)].location;

if ([body rangeOfString:@" " options:NSCaseInsensitiveSearch range:NSMakeRange (start_link_pos, bodyLength - start_link_pos)].location != NSNotFound)
end_link_pos = [body rangeOfString:@" " options:NSCaseInsensitiveSearch range:NSMakeRange (start_link_pos, bodyLength - start_link_pos)].location;

// also try newline character if space is not found
int new_line_pos = [body rangeOfString:@"\n" options:NSCaseInsensitiveSearch range:NSMakeRange (start_link_pos, bodyLength - start_link_pos)].location;
int new_line_pos;
if ([body rangeOfString:@"\n" options:NSCaseInsensitiveSearch range:NSMakeRange (start_link_pos, bodyLength - start_link_pos)].location != NSNotFound)
new_line_pos = [body rangeOfString:@"\n" options:NSCaseInsensitiveSearch range:NSMakeRange (start_link_pos, bodyLength - start_link_pos)].location;

// use the one that is closest to the http
if (new_line_pos != NSNotFound)
{
Expand Down Expand Up @@ -153,10 +164,16 @@ - (NSMutableArray *) parseBodyForDescribedLinks:(NSMutableDictionary *) comment
BOOL linksAvailable = TRUE;

while (linksAvailable) {
lsqb = [body rangeOfString:@"[" options:NSCaseInsensitiveSearch range:NSMakeRange (pos, bodyLength - pos)].location + 1;
rsqb = [body rangeOfString:@"](" options:NSCaseInsensitiveSearch range:NSMakeRange (lsqb, bodyLength - lsqb)].location;

//do a check for ending brackets first
if ([body rangeOfString:@"])"].location == NSNotFound)
break;

lsqb = [body rangeOfString:@"[" options:NSCaseInsensitiveSearch range:NSMakeRange (pos, bodyLength - pos)].location + 1; //index of left square bracket
rsqb = [body rangeOfString:@"](" options:NSCaseInsensitiveSearch range:NSMakeRange (lsqb, bodyLength - lsqb)].location; ////index of right square bracket
lrb = rsqb + 2;
rrb = [body rangeOfString:@")" options:NSCaseInsensitiveSearch range:NSMakeRange (lrb, bodyLength - lrb)].location;

if (lsqb != NSNotFound && rsqb != NSNotFound && rrb != NSNotFound)
{
link_counter++;
Expand Down