Skip to content

feat(SCRUM-87): SCRUM-87-orders-details#8

Merged
mariam-mohamed00 merged 12 commits into
feature/SCRUM-80-home-orderfrom
feature/SCRUM-87-drivers-orders-details
Feb 28, 2026
Merged

feat(SCRUM-87): SCRUM-87-orders-details#8
mariam-mohamed00 merged 12 commits into
feature/SCRUM-80-home-orderfrom
feature/SCRUM-87-drivers-orders-details

Conversation

@mariam-mohamed00
Copy link
Copy Markdown
Collaborator

No description provided.

@elevate-flutter-team
Copy link
Copy Markdown
Collaborator

🚧 Automated Code Review

Score: 2/100

📋 Summary

  • ⚠️ Large PR: 35 files (Keep it small).
  • ❌ 1 Generated files (.g.dart) found.
  • ❌ 12 functions exceed 20 lines.
  • ⚠️ 18 hardcoded colors.

🔍 Detected Issues

File Category Issue
...colors.dart Design Use Theme.of(context) or AppColors
static const Color lightPink = Color(0xF...
...drivers_orders_details_page.dart Maintainability Function 'build' exceeds 20 lines
build()...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
icon: const Icon(Icons.arrow_back_ios, c...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
color: AppColors.blackColor,...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
? AppColors.green...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
: AppColors.lightGrey,...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
color: AppColors.lightPink,...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
color: AppColors.green,...
...drivers_orders_details_page.dart Design Use Theme.of(context) or AppColors
color: AppColors.grey,...
...address_card.dart Maintainability Function 'build' exceeds 20 lines
build()...
...address_card.dart Design Use Theme.of(context) or AppColors
border: Border.all(color: AppColors.ligh...
...address_card.dart Design Use Theme.of(context) or AppColors
color: AppColors.blackColor,...
...address_card.dart Design Use Theme.of(context) or AppColors
color: AppColors.blackColor,...
...address_card.dart Design Use Theme.of(context) or AppColors
icon: Icon(Icons.phone_outlined, color: ...
...address_card.dart Design Use Theme.of(context) or AppColors
color: AppColors.pink,...

(...and 16 more issues)

Review generated for Mariam Mohamed

Comment thread lib/features/driver_orders_details/data/repos/order_details_repo_impl.dart Outdated
Comment thread lib/features/driver_orders_details/domain/usecases/get_order_details_usecase.dart Outdated
Comment thread lib/features/driver_orders_details/presentation/manager/order_details_cubit.dart Outdated
),
const SizedBox(height: 4),
Text(
'Wed, 03 Sep 2024, 11:00 AM',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid using hard coded string

@mariam-mohamed00 mariam-mohamed00 changed the base branch from dev to feature/SCRUM-80-home-order February 27, 2026 23:56
@mariam-mohamed00 mariam-mohamed00 merged commit f75374f into feature/SCRUM-80-home-order Feb 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants