feat(SCRUM-73): SCRUM-73-home by alibesar7 · Pull Request #7 · alibesar7/tracking_app

alibesar7 · 2026-02-18T20:52:30Z

No description provided.

elevate-flutter-team · 2026-02-18T21:15:01Z

🚧 Automated Code Review

Score: 0/100

📋 Summary

⚠️ Large PR: 37 files (Keep it small).
❌ 2 Generated files (.g.dart) found.
❌ 2 functions exceed 20 lines.
⚠️ 21 hardcoded colors.
❌ 27 naming convention errors.

🔍 Detected Issues

File	Category	Issue
...di.config.dart	Naming	File must be snake_case `di.config.dart...`
...api_client.g.dart	Config	Do not commit generated files (.g.dart) `N/A...`
...app_section_view.dart	Maintainability	Function 'build' exceeds 20 lines `build()...`
...driverOrderDataS_imp.dart	Naming	File must be snake_case `driverOrderDataS_imp.dart...`
...driverOrderDatascource.dart	Naming	File must be snake_case `driverOrderDatascource.dart...`
...orderRespons.dart	Naming	File must be snake_case `orderRespons.dart...`
...driverOrderRepo_impl.dart	Naming	File must be snake_case `driverOrderRepo_impl.dart...`
...driverOrderRepo.dart	Naming	File must be snake_case `driverOrderRepo.dart...`
...getdriverOrderUsecase.dart	Naming	File must be snake_case `getdriverOrderUsecase.dart...`
...driverorderCubit.dart	Naming	File must be snake_case `driverorderCubit.dart...`
...driverorderIntent.dart	Naming	File must be snake_case `driverorderIntent.dart...`
...driverorderStates.dart	Naming	File must be snake_case `driverorderStates.dart...`
...driverOrderScreen.dart	Naming	File must be snake_case `driverOrderScreen.dart...`
...driverOrderButton.dart	Naming	File must be snake_case `driverOrderButton.dart...`
...driverOrderButton.dart	Design	Use Theme.of(context) or AppColors `color: isPrimary ? const Color(0xFFE91E6...`

(...and 37 more issues)

Review generated for Alibesar

…ollection

…type

Copilot

Pull request overview

This pull request implements a driver order management feature (SCRUM-73) for a Flutter tracking application. The feature allows drivers to view and manage pending delivery orders through a new home screen interface. The implementation follows a clean architecture pattern with comprehensive test coverage.

Changes:

Added complete driver order feature with data, domain, and presentation layers
Updated dependencies (retrofit 4.4.1 → 4.9.1, retrofit_generator 7.0.8 → 10.2.3)
Integrated new driver order screen as the default home view in the app sections
Added English and Arabic translations for all driver order UI elements

Reviewed changes

Copilot reviewed 35 out of 37 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
lib/features/home/data/model/response/orderRespons.dart	New data model for order responses with nested entities (Order, Store, User, etc.)
lib/features/home/data/datascourse/driverOrderDatascource.dart	Abstract data source interface for driver orders
lib/features/home/api/driverOrderDataS_imp.dart	Implementation of data source using API client
lib/features/home/data/repo/driverOrderRepo_impl.dart	Repository implementation delegating to data source
lib/features/home/domain/repo/driverOrderRepo.dart	Domain layer repository interface
lib/features/home/domain/usecase/getdriverOrderUsecase.dart	Use case for fetching pending driver orders
lib/features/home/presentation/manger/driverorderCubit.dart	State management cubit handling order fetching and removal
lib/features/home/presentation/manger/driverorderStates.dart	State class for driver order feature
lib/features/home/presentation/manger/driverorderIntent.dart	Intent classes for cubit actions
lib/features/home/presentation/pages/driverOrderScreen.dart	Main screen widget for driver orders
lib/features/home/presentation/widgets/driverScreenBody.dart	Body widget with order list and state handling
lib/features/home/presentation/widgets/driverOrderItem.dart	Individual order card widget
lib/features/home/presentation/widgets/driverOrderInfoCard.dart	Reusable card for store/user information
lib/features/home/presentation/widgets/driverOrderButton.dart	Reusable button component for accept/reject actions
lib/features/home/presentation/widgets/driverOrderSectionLabel.dart	Label widget for section headers
lib/features/app_sections/presentation/widgets/app_section_view.dart	Updated to use DriverOrderScreen as home view
lib/app/core/api_manger/api_client.dart	Added getPendingOrders API method
lib/app/core/api_manger/api_client.g.dart	Generated Retrofit API client code
lib/app/core/values/app_endpoint_strings.dart	Added driverOrders endpoint constant
lib/app/config/di/di.config.dart	Dependency injection configuration for new feature
lib/features/profile/data/models/requests/edit_profile_request.g.dart	Updated generated JSON serialization code
pubspec.yaml	Dependency version updates for retrofit packages
pubspec.lock	Lock file with updated dependency versions
assets/translations/en.json	Added English translations for driver order UI
assets/translations/ar.json	Added Arabic translations for driver order UI
test/features/home/*	Comprehensive test suite covering all layers (8 test files)
test/features/app_sections/presentation/widgets/app_section_view_test.dart	Updated to test DriverOrderScreen integration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-26T00:00:32Z

+abstract class DriverOrderDataSource {
+  Future<ApiResult<OrderResponse>> getPendingOrders(String token);


The file name 'driverOrderDatascource.dart' has a spelling error. It should be 'driverOrderDatasource.dart' (with 'source' not 'scource'). The interface inside is correctly named 'DriverOrderDataSource', so the file name should match this spelling.

Copilot · 2026-02-26T00:00:33Z

+import 'package:tracking_app/features/home/domain/repo/driverOrderRepo.dart';
+
+@injectable
+class GetDriverOrdersUseCase {


File naming doesn't follow Dart conventions. The file name 'getdriverOrderUsecase.dart' should use snake_case as per Dart style guide. Consider renaming to 'get_driver_order_usecase.dart' to match the standard Dart file naming convention and improve readability.

Copilot · 2026-02-26T00:00:33Z

+            image: order.user?.photo != null
+                ? "https://flower.elevateegy.com/uploads/${order.user!.photo!}"


Hardcoded base URL "https://flower.elevateegy.com/uploads/" is used to construct the image URL. This should be extracted to a constant (e.g., in AppEndpointString or a similar configuration file) to make it easier to change for different environments (dev, staging, production) and maintain consistency across the codebase.

Copilot · 2026-02-26T00:00:33Z

+import 'package:tracking_app/features/home/presentation/manger/driverorderIntent.dart';
+import 'package:tracking_app/features/home/presentation/manger/driverorderStates.dart';


The directory name "manger" is a spelling error. It should be "manager" (as used in other features like app_sections) or "managers" (as used in the profile feature). A "manger" is a feeding trough for animals, while "manager" refers to management/state management code. Consider renaming this directory to maintain consistency and correct spelling.

Suggested change

import 'package:tracking_app/features/home/presentation/manger/driverorderIntent.dart';

import 'package:tracking_app/features/home/presentation/manger/driverorderStates.dart';

import 'package:tracking_app/features/home/presentation/manager/driverorderIntent.dart';

import 'package:tracking_app/features/home/presentation/manager/driverorderStates.dart';

Copilot · 2026-02-26T00:00:33Z

+Map<String, dynamic> _$EditProfileRequestToJson(EditProfileRequest instance) =>
+    <String, dynamic>{
+      'firstName': ?instance.firstName,
+      'lastName': ?instance.lastName,
+      'email': ?instance.email,
+      'phone': ?instance.phone,
+      'vehicleType': ?instance.vehicleType,
+      'vehicleNumber': ?instance.vehicleNumber,
+      'vehicleLicense': ?instance.vehicleLicense,
+    };


The generated JSON serialization code uses unusual syntax with the '?' prefix operator (e.g., '?instance.firstName'). This appears to be invalid Dart syntax. The json_serializable package with 'includeIfNull: false' should generate proper null-checking code. This might be caused by a bug in the json_serializable version being used, or the generated code needs to be regenerated after the package update. Run 'dart run build_runner build --delete-conflicting-outputs' to regenerate this file.

Suggested change

Map<String, dynamic> _$EditProfileRequestToJson(EditProfileRequest instance) =>

<String, dynamic>{

'firstName': ?instance.firstName,

'lastName': ?instance.lastName,

'email': ?instance.email,

'phone': ?instance.phone,

'vehicleType': ?instance.vehicleType,

'vehicleNumber': ?instance.vehicleNumber,

'vehicleLicense': ?instance.vehicleLicense,

};

Map<String, dynamic> _$EditProfileRequestToJson(EditProfileRequest instance) {

final val = <String, dynamic>{};

void writeNotNull(String key, dynamic value) {

if (value != null) {

val[key] = value;

}

}

writeNotNull('firstName', instance.firstName);

writeNotNull('lastName', instance.lastName);

writeNotNull('email', instance.email);

writeNotNull('phone', instance.phone);

writeNotNull('vehicleType', instance.vehicleType);

writeNotNull('vehicleNumber', instance.vehicleNumber);

writeNotNull('vehicleLicense', instance.vehicleLicense);

return val;

}

Copilot · 2026-02-26T00:00:34Z

+
+  @GET(AppEndpointString.driverOrders)
+  Future<HttpResponse<OrderResponse>> getPendingOrders(
+    @Header("Authorization") String token,


Inconsistent use of header annotation. The getPendingOrders method uses @Header("Authorization") with a hardcoded string, while other methods in the same class use @Header(ApiConstants.authorization) referencing the constant. For consistency and maintainability, consider using the constant instead of the hardcoded string.

Suggested change

@Header("Authorization") String token,

@Header(ApiConstants.authorization) String token,

Copilot · 2026-02-26T00:00:34Z

@@ -0,0 +1,277 @@
+import 'package:json_annotation/json_annotation.dart';
+
+part 'orderRespons.g.dart';


The file name 'orderRespons.dart' appears to have a typo. It should be 'orderResponse.dart' (with an 'e' at the end). The class inside is named 'OrderResponse' correctly, so the file name should match. This affects imports throughout the codebase.

Suggested change

part 'orderRespons.g.dart';

part 'orderResponse.g.dart';

Copilot · 2026-02-26T00:00:35Z

+  DriverOrderCubit(this._getDriverOrdersUseCase, this._authStorage)
+    : super(DriverOrderState());
+
+  void onIntent(DriverOrderIntent intent) {


The method name "onIntent" is inconsistent with the established naming convention in the codebase. Other Cubits like LoginCubit use "doAction" as the method name for handling intents. This inconsistency could confuse developers maintaining the codebase. Consider renaming this method to "doAction" to maintain consistency.

Suggested change

void onIntent(DriverOrderIntent intent) {

void doAction(DriverOrderIntent intent) {

Copilot · 2026-02-26T00:00:35Z

+import 'package:tracking_app/features/home/presentation/manger/driverorderStates.dart';
+
+@injectable
+class DriverOrderCubit extends Cubit<DriverOrderState> {


File naming is inconsistent with the codebase conventions. The file uses camelCase (driverorderCubit.dart) but should follow the established pattern. Looking at the codebase, files use either snake_case (profile_cubit.dart, login_cubit.dart) or in some older files PascalCase/camelCase. For consistency and Dart best practices, consider renaming to 'driver_order_cubit.dart' to match the snake_case convention typically used for Dart files.

Copilot · 2026-02-26T00:00:35Z

+abstract class DriverOrderDataSource {
+  Future<ApiResult<OrderResponse>> getPendingOrders(String token);


The directory name 'datascourse' is a spelling error. It should be 'datasource' (with an 'o' before 'u'). A "datasource" is a source of data, while "datascourse" is not a valid English word. This affects the import paths throughout the codebase.

feat(SCRUM-73): SCRUM-73-acc

…e/SCRUM-80-home-order

…d refactor related components

…setup and assertions

…re/SCRUM-87-drivers-orders-details

…anup

…details feat(SCRUM-87): SCRUM-87-orders-details

mariam-mohamed00 and others added 4 commits February 18, 2026 00:51

feat(SCRUM-87): implement initial order deatils ui page with static data

2fd7df9

chore(API-1): handel CA

cc3027e

chore(API-1): make unite test

5b724c0

chore(API-1): fin u w test

581c7d2

alibesar7 changed the title ~~Feature/scrum 80 home order~~ feat(SCRUM-80): SCRUM-80-home-order Feb 18, 2026

alibesar7 changed the title ~~feat(SCRUM-80): SCRUM-80-home-order~~ feat(SCRUM-73): SCRUM-73-home Feb 18, 2026

nouran2005 and others added 2 commits February 18, 2026 22:56

feat(SCRUM-88): start my order feature

cd6c485

chore(API-1): fin u w testt

aac89d4

mariam-mohamed00 and others added 21 commits February 18, 2026 23:28

feat(SCRUM-87): adding data&domain layers to get data from firebase c…

c1b4c06

…ollection

feat(SCRUM-87): Unit test and wigdet test for order deatils feature

54ab985

fix(SCRUM-87): update versions

efc019e

fix(SCRUM-87): update ver

991e344

feat(SCRUM-88): finish datasource and models

2ae336d

refactor(SCRUM-87): refactor functions by using api result in return …

1c72f13

…type

chore(API-1): add driver order

a3ede73

chore(API-1): fin accept

f86d235

chore(API-1): fin acceptt

63e6b87

feat(SCRUM-88): finish data and domain layers

cfad3a3

feat(SCRUM-88): finish cubit and ui of my order screen

2bbb02a

feat(SCRUM-88): comment a widget test in app section

38d1fe0

feat(SCRUM-88): finish my orders screen UI with cubit integration

46b88b8

feat(SCRUM-88): finish unit test

391cf65

feat(SCRUM-88): finish the widget test

8c7e7b1

feat(SCRUM-88): finish ui of my order details

e3fd8f7

feat(SCRUM-88): finish widget test for oder details

be808e0

feat(SCRUM-88): change version of retrofit_generator in pubspect

336bb2a

feat(SCRUM-88): finish

558c9f3

feat(SCRUM-87): update models and mapper, refactor unit tests

c0f790a

Merge branch 'dev' into feature/SCRUM-87-drivers-orders-details

f7958e6

nouran2005 added 3 commits February 22, 2026 00:22

feat(SCRUM-88): refactor pubspec yaml

57d80e4

feat(SCRUM-88): refactor pubspect

17e718f

feat(SCRUM-88): fix

9bd0611

elevate-flutter-team requested a review from Copilot February 25, 2026 23:52

Copilot started reviewing on behalf of elevate-flutter-team February 25, 2026 23:52 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

alibesar7 and others added 10 commits February 27, 2026 15:16

Merge pull request #9 from alibesar7/feature/SCRUM-85-accept

7a6e240

feat(SCRUM-73): SCRUM-73-acc

feat(SCRUM-88): Merge branch 'feature/SCRUM-88-my-orders' into featur…

c798e93

…e/SCRUM-80-home-order

feat(SCRUM-87): enhance order details with new status translations an…

ccd6fb8

…d refactor related components

test(SCRUM-87): enhance OrderDetailsCubit tests with additional mock …

bfcc5a4

…setup and assertions

feat(SCRUM-87): Merge branch 'feature/SCRUM-80-home-order' into featu…

8279e06

…re/SCRUM-87-drivers-orders-details

refactor(SCRUM-87): remove OrderDetailsCubit test file as part of cle…

f8ca783

…anup

Merge pull request #8 from alibesar7/feature/SCRUM-87-drivers-orders-…

f75374f

…details feat(SCRUM-87): SCRUM-87-orders-details

chore(API-1): fix stream snapshot

12ef52c

chore(API-1): fix stream snapshots

71eea36

chore(API-1): add location permissions to AndroidManifest.xml

ed903af

elevate-flutter-team merged commit ed903af into dev Feb 28, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(SCRUM-73): SCRUM-73-home#7

feat(SCRUM-73): SCRUM-73-home#7
elevate-flutter-team merged 40 commits into
devfrom
feature/SCRUM-80-home-order

alibesar7 commented Feb 18, 2026

Uh oh!

elevate-flutter-team commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Copilot AI Feb 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		abstract class DriverOrderDataSource {
		Future<ApiResult<OrderResponse>> getPendingOrders(String token);

		image: order.user?.photo != null
		? "https://flower.elevateegy.com/uploads/${order.user!.photo!}"

		import 'package:tracking_app/features/home/presentation/manger/driverorderIntent.dart';
		import 'package:tracking_app/features/home/presentation/manger/driverorderStates.dart';

-Map<String, dynamic> _$EditProfileRequestToJson(EditProfileRequest instance) =>
-    <String, dynamic>{
-      'firstName': ?instance.firstName,
-      'lastName': ?instance.lastName,
-      'email': ?instance.email,
-      'phone': ?instance.phone,
-      'vehicleType': ?instance.vehicleType,
-      'vehicleNumber': ?instance.vehicleNumber,
-      'vehicleLicense': ?instance.vehicleLicense,
-    };
+Map<String, dynamic> _$EditProfileRequestToJson(EditProfileRequest instance) {
+  final val = <String, dynamic>{};
+  void writeNotNull(String key, dynamic value) {
+    if (value != null) {
+      val[key] = value;
+    }
+  }
+  writeNotNull('firstName', instance.firstName);
+  writeNotNull('lastName', instance.lastName);
+  writeNotNull('email', instance.email);
+  writeNotNull('phone', instance.phone);
+  writeNotNull('vehicleType', instance.vehicleType);
+  writeNotNull('vehicleNumber', instance.vehicleNumber);
+  writeNotNull('vehicleLicense', instance.vehicleLicense);
+  return val;
+}

	@Header("Authorization") String token,
	@Header(ApiConstants.authorization) String token,

		@@ -0,0 +1,277 @@
		import 'package:json_annotation/json_annotation.dart';

		part 'orderRespons.g.dart';

	void onIntent(DriverOrderIntent intent) {
	void doAction(DriverOrderIntent intent) {

Conversation

alibesar7 commented Feb 18, 2026

Uh oh!

elevate-flutter-team commented Feb 18, 2026

🚧 Automated Code Review

📋 Summary

🔍 Detected Issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants