Skip to content

fix simulator Close block #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damoye wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix simulator Close block #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions pkg/simulator/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,7 @@ func Simulate(cluster ResourceTypes, apps []AppResource, opts ...Option) (*Simul
trace := utiltrace.New("Trace Simulate")
defer trace.LogIfLong(1 * time.Second)

// init simulator
sim, err := NewSimulator(opts...)
if err != nil {
return nil, err
}
defer func() {
sim.Close()
}()
trace.Step("Trace Simulate init done")

var err error
cluster.Pods, err = GetValidPodExcludeDaemonSet(cluster)
if err != nil {
return nil, err
Expand All @@ -95,6 +86,16 @@ func Simulate(cluster ResourceTypes, apps []AppResource, opts ...Option) (*Simul
}
trace.Step("Trace Simulate make valid pod done")

// init simulator
sim, err := NewSimulator(opts...)
if err != nil {
return nil, err
}
defer func() {
sim.Close()
}()
trace.Step("Trace Simulate init done")

var failedPods []UnscheduledPod
// run cluster
result, err := sim.RunCluster(cluster)
Expand Down