refactor(ci): unify RPM build pipeline via rpm.yaml#496
Draft
samchu-zsl wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
Caution This PR was generated and submitted by AI. |
Collaborator
Author
Collaborator
|
The only remaining point to align on : whether ws-ckpt should be included in the nightly Docker pipeline?ws-ckpt has been removed from the current Nightly image build pipeline. |
Collaborator
Author
The ws-ckpt RPM package cannot be installed in Docker containers because its installation process requires modprobe. Tracked in Issue #501. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Unifies the RPM build pipeline by introducing a single reusable workflow (
.github/workflows/rpm.yaml) that is shared between the nightly (docker-nightly.yaml) and tag-driven release (release.yaml) flows. The pipeline handles source/vendor packaging and per-arch RPM construction in one place, replacing the previous three-way split (_rpm-build.yaml+ inline packaging in nightly + inline packaging in release). On top of the refactor, this PR also resolves a few accumulated CI issues: the(409) Conflicton artifact uploads during a release run, a sec-core source selection that went stale whenever development moved betweenmainand the release branch, and several tokenless RPM packaging bugs.Related Issue
no-issue: internal CI reliability / refactor work; no user-facing ticket.
Type of Change
Scope
cosh(copilot-shell)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)Checklist
cosh: Lint passes, type check passes, and tests passsec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpasspackage-lock.json/Cargo.lock)Testing
Additional Notes
Key behavioural changes reviewers should scrutinise:
0 16 * * *(Beijing 00:00) to0 20 * * *(Beijing 04:00).detect-sec-corenow compares the last-touched commit time undersrc/agent-sec-core/betweenrelease/sec-core/v*andmain, and picks whichever is newer. This matches the fluid branch management reality for sec-core.ws-ckptis removed from the nightly pipeline and marked TODO alongsideagentsightuntil its integration lands.release.yamlno longer runspackage-source/package-vendoritself. All artifacts (source tarball, vendor tarball, per-arch RPMs) are produced byrpm.yamland consumed by thepublishjob from the same workflow run. The previousarchive-sha256cross-job checksum check was removed because same-run artifacts are implicitly trusted.src/tokenless/tokenless.spec.in:BuildRequires: cargoandrust >= 1.86are commented out; the CI environment provides these directly, and local builders must install them manually.%setup -q -n tokenless→%setup -q, so the macro expands to the default%{name}-%{version}, matching the tarball produced bypackage-source.cargo build ... toon ... || trueloses the|| truefallback; the toon submodule build is now a hard requirement (Rust 1.93 in CI satisfies it).Rollback is a straight revert of the single commit; changes are isolated to CI/workflow files and one RPM spec.