feat: implement OSSFS storage backend in sandbox lifecycle#340
Merged
Pangjiping merged 11 commits intoalibaba:mainfrom Mar 16, 2026
Merged
feat: implement OSSFS storage backend in sandbox lifecycle#340Pangjiping merged 11 commits intoalibaba:mainfrom
Pangjiping merged 11 commits intoalibaba:mainfrom
Conversation
hittyt
requested review from
Generalwin,
Pangjiping,
Spground,
fengcone,
jwx0925,
kevinlynx and
ninan-nn
as code owners
Pangjiping
reviewed
Mar 4, 2026
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a72893a549
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hittyt
force-pushed
the
feat/support-ossfs-api
branch
from
a72893a to
ce216ac
Compare
Collaborator
|
Please rebase main to resolve pyproject.toml format error |
hittyt
force-pushed
the
feat/support-ossfs-api
branch
from
ce216ac to
c12516d
Compare
hittyt
force-pushed
the
feat/support-ossfs-api
branch
from
aaf4e73 to
25eb4ed
Compare
Pangjiping
requested changes
Mar 7, 2026
hittyt
force-pushed
the
feat/support-ossfs-api
branch
2 times, most recently
from
11e4b44 to
8338c4d
Compare
Collaborator
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8338c4d7cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Implement OSSFS volume support in Docker runtime with mount reference counting. - Add comprehensive validation and unit tests for the new storage backend.
…vior Move Docker OSSFS-specific logic into a dedicated module to reduce branching noise in the core provisioning flow, and align OSSFS request validation with schema-driven constraints and platform support boundaries. This also fixes server pyproject TOML parsing so validation/test tooling can run reliably. Made-with: Cursor
Make OSSFS mount preparation transactional by rolling back already prepared mount keys when a later mount in the same batch fails. Add a regression test to prevent ref-count leaks in multi-volume partial-failure scenarios. Made-with: Cursor
Remove endpoint-derived region/sigv4 auto-injection for OSSFS 1.0 so region semantics stay explicitly controlled by caller options. Add assertions to keep v1 command generation free of implicit region flags. Made-with: Cursor
Install and expose both JDK 8 and JDK 17 in Java E2E so Gradle toolchain resolution does not depend on foojay auto-download in CI. Configure Gradle installation paths explicitly to avoid intermittent Java 8 provisioning failures. Made-with: Cursor
- Widen try/except in _provision_sandbox to cover all post-OSSFS steps (volume binds, sidecar, container creation) so mounts are always released on failure. - Two-pass startup restore: populate OSSFS ref counts for all containers before expiring any, preventing untracked-key skips during cleanup. - Add fallback_mount_keys to _expire_sandbox so vanished containers (404) still release their cached refs. - Retry expiration on transient Docker errors (non-404) with 30s delay, preserving fallback keys and original expiresAt timestamp. - Guard against renew/retry race: revalidate expiration deadline before kill/remove to avoid terminating a renewed sandbox. - Fix cross-platform test stability: pin os.name in OSSFS tests and correct patch paths to ossfs_mixin. Made-with: Cursor
hittyt
force-pushed
the
feat/support-ossfs-api
branch
from
8338c4d to
9b621de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the OSSFS storage backend for the sandbox lifecycle, as detailed in OSEP-0003.
Key features:
ossfsmounting.