Skip to content

feat(csharp-sdk): improve ready-timeout diagnostics#313

Merged
ninan-nn merged 1 commit intoalibaba:mainfrom
liuxiaopai-ai:codex/csharp-ready-timeout-diagnostics
Mar 9, 2026
Merged

feat(csharp-sdk): improve ready-timeout diagnostics#313
ninan-nn merged 1 commit intoalibaba:mainfrom
liuxiaopai-ai:codex/csharp-ready-timeout-diagnostics

Conversation

@liuxiaopai-ai
Copy link
Copy Markdown
Contributor

Summary

  • improve C# SDK WaitUntilReadyAsync timeout diagnostics with:
    • attempt count
    • last health-check error detail
    • connection context (domain, useServerProxy)
    • actionable hints for bridge/remote network setups
  • add C# unit tests to validate the new diagnostics behavior

Why

Users troubleshooting readiness timeouts need actionable context in exception messages. This aligns C# SDK with the same troubleshooting direction introduced for Python/JavaScript SDKs.

Validation

  • git diff --check
  • could not run C# tests locally because dotnet is not available in this execution environment; CI should run the added test suite

@Pangjiping Pangjiping added feature New feature or request sdk/c# labels Mar 3, 2026
Copy link
Copy Markdown
Collaborator

@ninan-nn ninan-nn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Rebase Main Plz : >

@liuxiaopai-ai liuxiaopai-ai force-pushed the codex/csharp-ready-timeout-diagnostics branch from 7ab1313 to 9be3c02 Compare March 9, 2026 04:45
@liuxiaopai-ai
Copy link
Copy Markdown
Contributor Author

Rebased onto the latest main and force-pushed the branch. Please take another look when you have a moment. Thanks!

@liuxiaopai-ai
Copy link
Copy Markdown
Contributor Author

@ninan-nn Rebased onto the latest main and force-pushed the branch. Could you please take another look when you have a moment? Thanks!

@ninan-nn ninan-nn merged commit aea52c0 into alibaba:main Mar 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request sdk/c#

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants