feat(js-sdk): improve sandbox ready-timeout diagnostics#311
Merged
ninan-nn merged 1 commit intoalibaba:mainfrom Mar 9, 2026
Merged
Conversation
liuxiaopai-ai
requested review from
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
ninan-nn
requested changes
Mar 9, 2026
Collaborator
ninan-nn
left a comment
ninan-nn
left a comment
There was a problem hiding this comment.
LGTM, Rebase Main Plz : >
liuxiaopai-ai
force-pushed
the
codex/js-ready-timeout-diagnostics
branch
from
8c7afcb to
4209575
Compare
Contributor
Author
|
Rebased onto the latest |
Contributor
Author
|
@ninan-nn Rebased onto the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitUntilReadytimeout message with:domain,useServerProxy)Why
Users hitting readiness timeout (for example in bridge network setups) need immediate, actionable diagnostics instead of a generic timeout error.
This aligns JavaScript SDK ergonomics with the improved troubleshooting direction already added in Python SDK.
Validation
pnpm -C sdks/sandbox/javascript run lintpnpm -C tests/javascript run lintcd tests/javascript && pnpm run prep:sdk && pnpm exec vitest run tests/test_wait_until_ready_diagnostics.test.ts