fix(interactive): fix bugs in get_v and edge expand#4617
Open
liulx20 wants to merge 6 commits intoalibaba:mainfrom
Open
fix(interactive): fix bugs in get_v and edge expand#4617liulx20 wants to merge 6 commits intoalibaba:mainfrom
liulx20 wants to merge 6 commits intoalibaba:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses bugs in the get_v operation and refines the edge expand logic by updating how label triplets are processed and modifying error handling.
- In edge expand, label filtering now selectively populates the labels based on provided tables and direction.
- In get_v, the error branch for mismatched output vertex labels now constructs a valid context using a builder rather than returning a bad request error.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flex/engines/graph_db/runtime/execute/ops/retrieve/edge.cc | Updated label filtering logic based on tables and direction |
| flex/engines/graph_db/runtime/common/operators/retrieve/get_v.h | Changed error handling behavior and added a new branch for single-label processing |
Comments suppressed due to low confidence (2)
flex/engines/graph_db/runtime/execute/ops/retrieve/edge.cc:646
- When filtering labels based on the provided tables and direction, if none of the labels meet the criteria, eep.labels may be empty even if the original parsed labels (temps) are non-empty. Consider adding a fallback to assign 'temps' when no labels are selected to preserve expected behavior.
for (auto& label : temps) {
flex/engines/graph_db/runtime/common/operators/retrieve/get_v.h:202
- The error handling change for an output vertex label mismatch now returns a context built from a builder instead of returning a bad request error. Confirm that this new behavior is intentional to avoid unexpected downstream processing.
auto builder = SLVertexColumnBuilder::builder(output_vertex_label);
Contributor
|
/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as titled.