-
Notifications
You must be signed in to change notification settings - Fork 12
fix: add missing reject version field, fix tx id calculation in block models, and updates OAS indexer definitions #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da3cd66 to
ae6201b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the Algorand client models, particularly focusing on transaction ID consistency and proper handling of binary fields. The most significant changes include ensuring that transaction IDs are correctly populated with genesis information, updating key/value fields to use bytes with base64 encoding/decoding, and adding a test to verify transaction ID consistency between the algod and indexer clients.
Transaction ID Consistency and Genesis Info Handling
__post_init__method to theBlockclass in both the OAS generator and algod client models to automatically populategenesis_idandgenesis_hashfields for transactions in a block if they are missing, ensuring transaction IDs are computed correctly. [1] [2]Binary Field Handling and Serialization
EvalDeltaKeyValueandTealKeyValuemodels to usebytesfor thekeyfield instead ofstr, and applied base64 encoding/decoding for serialization and deserialization. [1] [2]bytes_field in theEvalDeltamodel to usebyteswith base64 encoding/decoding, ensuring correct binary data handling.App Call Transaction Model Update
reject_versionto theAppCallTransactionFieldsmodel, mapped to the wire name"aprv".