Hide bounty management actions from unauthorized users#256
Open
xh-stack wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Edit AmountandDeletecontrols on the organization bounties page unless the current user is an admin or moderatorcan_manage_bounties?/1helper for the UI and LiveView event authorization checksSecurity impact
The backend already rejects unauthorized edit/delete events, but non-admin users could still see management controls and trigger authorization error states. This change removes those controls from unauthorized users' rendered UI and keeps the backend authorization intact.
Fixes #238.
Testing
Not run locally. I used the GitHub API path for the patch because local
git fetchagainst the fork repeatedly timed out in this environment.