fix: hide Edit Amount and Delete buttons for unauthorized users#253
Open
nguyenquockhang1610 wants to merge 1 commit into
Open
fix: hide Edit Amount and Delete buttons for unauthorized users#253nguyenquockhang1610 wants to merge 1 commit into
nguyenquockhang1610 wants to merge 1 commit into
Conversation
The Edit Amount and Delete buttons on the org bounties page were visible to all logged-in users, even though the backend correctly rejects unauthorized actions. Now the buttons are only rendered when current_user_role is :admin or :mod. Fixes algora-io#238
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Edit Amount" and "Delete" buttons on the org bounties page are visible to all logged-in users, even though the backend correctly rejects unauthorized actions with a flash message.
Fix
Wrap the action buttons in a
current_user_role in [:admin, :mod]check, matching the same authorization logic already used in the event handlers (handle_event("delete-bounty", ...)andhandle_event("edit-bounty-amount", ...)).Buttons are now only rendered for users with admin or mod roles.
Fixes #238