Skip to content

Force external bounty links to open in _blank target to preserve navigation context #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihangwu539-png wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Force external bounty links to open in _blank target to preserve navigation context #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/algora_web/components/bounties.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ defmodule AlgoraWeb.Components.Bounties do
<div class="relative -mx-2 -mt-2 overflow-auto scrollbar-thin">
<ul class="divide-y divide-border">
<%= for bounty <- @bounties do %>
<.link href={Bounty.url(bounty)} class="block whitespace-nowrap hover:bg-muted/50">
<.link href={Bounty.url(bounty)} target="_blank" rel="noopener noreferrer" class="block whitespace-nowrap hover:bg-muted/50">
<li class="flex items-center py-2 px-3">
<div class="flex-shrink-0 mr-3">
<.avatar class="h-8 w-8">
Expand Down
2 changes: 1 addition & 1 deletion lib/algora_web/live/org/bounties_new_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ defmodule AlgoraWeb.Org.BountiesNewLive do

<div class="flex shrink-0 items-center gap-1 whitespace-nowrap text-sm text-muted-foreground">
<.icon name="tabler-chevron-right" class="h-4 w-4" />
<.link href={Bounty.url(bounty)} class="hover:underline">
<.link href={Bounty.url(bounty)} target="_blank" rel="noopener noreferrer" class="hover:underline">
{Bounty.path(bounty)}
</.link>
</div>
Expand Down
2 changes: 1 addition & 1 deletion lib/algora_web/live/org/home_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ defmodule AlgoraWeb.Org.HomeLive do
class="flex shrink-0 items-center gap-1 whitespace-nowrap text-sm text-muted-foreground"
>
<.icon name="tabler-chevron-right" class="h-4 w-4" />
<.link href={Bounty.url(bounty)} class="hover:underline">
<.link href={Bounty.url(bounty)} target="_blank" rel="noopener noreferrer" class="hover:underline">
{Bounty.path(bounty)}
</.link>
</div>
Expand Down
4 changes: 4 additions & 0 deletions lib/algora_web/live/user/profile_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,17 @@ defmodule AlgoraWeb.User.ProfileLive do
<.link
:if={ticket.repository}
href={"https://github.com/#{ticket.repository.user.provider_login}/#{ticket.repository.name}/issues/#{ticket.number}"}
target="_blank"
rel="noopener noreferrer"
class="hover:underline"
>
{ticket.repository.name}#{ticket.number}
</.link>
<.link
:if={!ticket.repository && ticket.url}
href={ticket.url}
target="_blank"
rel="noopener noreferrer"
class="hover:underline"
>
{Algora.Util.path_from_url(ticket.url)}
Expand Down