Conversation
alexschimpf
left a comment
There was a problem hiding this comment.
Looks good to me. I think I need to update my PyPI token before I can deploy. It's been awhile since I've done it. I'll keep ya posted. Might be able to get to it this weekend.
|
Hey @alexschimpf! Happy New Year! Did you get a chance to update the pypi token for the deployment? |
|
Hi @alexschimpf! Following up, any updates? Also, I don't think I can help with the pypi token and deployment, but if you can think of a way, I'm all ears! |
|
@alexschimpf, what is the status on this? :) EDIT: @ofipify , tagging you since I saw you in the commit history :) this would be nice to merge (Y) |
|
Also bumping here because I ran into this error as well and was working on a similar fix. Any chance we can get this merged and a new version cut? |
|
Just another attempt @alexschimpf :) Please merge the PR and cut a new version. |
|
Just a quick update. This will be merged soon, and the new version should be out in about 2 weeks. |
|
Thank you. Much appreciated. |
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Tried using the package with python3.13 and hit this issue:
KeyError: "response_field'. Did you mean 'response_model"I believe it's because python3.13 is trying to be more helpful in the error message when it hits a TypeError:
Example:
"APIRouter.add_api_route() got an unexpected keyword argument 'response_field'. Did you mean 'response_model'?"The current parsing fails because it extracts
"response_field'. Did you mean 'response_model"from this error.Using
splitapproach is compatible with all versions.The tests pass here: https://github.com/OlegZv/fastapi-versionizer/actions/runs/12386557668
Changes
_add_rout_to_routerto extract the argument using string.splitmethod.3.12and3.13to the strategy matrix.actions/setup-pythonaction version to v5.3.0.(@alexschimpf tagging you because I cannot assign you for review :) )