This change allows for the cvv text box to be autofilled#32
Open
welchcode wants to merge 3 commits intoalexschimpf:masterfrom
Open
This change allows for the cvv text box to be autofilled#32welchcode wants to merge 3 commits intoalexschimpf:masterfrom
welchcode wants to merge 3 commits intoalexschimpf:masterfrom
Conversation
This change adds support for cvv automation and allows the user to pass in a cvv code as an argument. If the cvv is not null, then it will be used to autofill the cvv textbox.
Added support for cvv automation
welchcode
commented
Dec 2, 2020
Author
welchcode
left a comment
welchcode
left a comment
There was a problem hiding this comment.
line 98 should actually be 'if cvv is None'
alexschimpf
reviewed
Dec 3, 2020
| login_time=args.login_time, release_time=args.release_time, page_load_timeout=args.page_load_timeout, | ||
| screenshot_path=args.screenshot_path, html_path=args.html_path, select_payment=args.select_payment, | ||
| purchase=args.purchase, num_retries=args.num_retries, dont_quit=args.dont_quit) | ||
| purchase=args.purchase, num_retries=args.num_retries, dont_quit=args.dont_quit, cvv = args.cvv) |
Owner
There was a problem hiding this comment.
This should be registered with the parser using add_argument. Also needs to be added to the README.
Owner
|
@welchcode I guess this work has already been done in #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the cvv can be passed in as a parameter and will autofill the cvv textbox if it is passed in. It does not have to be passed in, but if it is the program will default to automatically using the cvv value.