Emit errors only when listeners are present #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this fix issue SAP#64? |
dotchev
reviewed
Nov 23, 2016
lib/protocol/Connection.js
Outdated
| self._state.receive = null; // a callback should be called only once | ||
| cb(err); | ||
| } else { | ||
| } else if (self.listenerCount('error')) { |
There was a problem hiding this comment.
listenerCount is present since v3.2.0, see https://nodejs.org/api/events.html#events_emitter_listenercount_eventname
package.json says "node": ">= 0.12"
we could do it like this
self.listenerCount && self.listenerCount('error') || self.listeners('error').length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.