Update type definitions to support React 19#210
Open
maruyamaworks wants to merge 1 commit intoalexkatz:mainfrom
Open
Update type definitions to support React 19#210maruyamaworks wants to merge 1 commit intoalexkatz:mainfrom
maruyamaworks wants to merge 1 commit intoalexkatz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alexkatz, thank you very much for your great work!
I have created this PR to make this library compatible with React 19!
In React 19, the global JSX namespace has been removed, so
JSX.Elementcannot be resolved and is treated asany. In this PR, animportstatement is added so thatJSX.Elementis correctly referenced.Also, the
useRefnow requires an argument in React 19, so I explicitly addedundefinedto theuseRef().