Skip to content

Tidy up#17

Merged
alexespencer merged 1 commit into
mainfrom
asp/tidy-up
Jun 1, 2025
Merged

Tidy up#17
alexespencer merged 1 commit into
mainfrom
asp/tidy-up

Conversation

@alexespencer

Copy link
Copy Markdown
Owner

No description provided.

@alexespencer alexespencer requested a review from Copilot June 1, 2025 17:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tidies up the visualize module by removing unused or redundant code and improving encapsulation in the Model structure. Key changes include removing the unused Technique enum, making some Model fields private and adding a setter for mouse_position, and updating related call sites throughout the codebase.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
visualize/src/model.rs Removed Technique enum; encapsulated Model fields; updated draw_app logic.
visualize/src/main.rs Replaced direct field assignments with setter calls; updated draw_app usage.
visualize/src/lib.rs Removed outdated export of Technique to match changes in model.rs.
Comments suppressed due to low confidence (3)

visualize/src/model.rs:20

  • Removal of the public Technique enum may break external consumers if they relied on it. Confirm that this export is no longer needed and update any dependent documentation or tests accordingly.
-pub enum Technique {

visualize/src/model.rs:23

  • Changing 'points', 'mouse_position', and 'region' from public to private improves encapsulation; ensure that all required external interactions with these fields now use provided accessor or setter methods.
pub struct Model {

visualize/src/model.rs:70

  • [nitpick] The update to draw_app now exclusively uses internal points, removing flexibility of drawing a custom set of points; verify that this change aligns with the overall design intentions.
pub fn draw_app(&self, draw: &Draw) {

@alexespencer alexespencer enabled auto-merge (squash) June 1, 2025 17:39
@alexespencer alexespencer merged commit 7da7279 into main Jun 1, 2025
1 check passed
@alexespencer alexespencer deleted the asp/tidy-up branch June 1, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants