Add nannou feature flag and use in visualisation#16
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new "nannou" feature flag and updates the code to leverage conversions between quadtree regions and nannou rectangles in the visualization module. Key changes include:
- Refactoring region conversion in visualize/src/model.rs to use Into/From implementations.
- Updating dependency declarations in Cargo.toml files to support the nannou feature.
- Adding cfg-based implementations in quadtree/src/region.rs and quadtree/src/quadtree.rs for nannou.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| visualize/src/model.rs | Refactored region creation using Into conversion from Rect. |
| visualize/Cargo.toml | Updated quadtree dependency to enable "nannou" feature and adjusted nannou/nannou_egui usage. |
| quadtree/src/region.rs | Added From/Into implementations between Region<2> and nannou::geom::Rect guarded by the nannou feature flag. |
| quadtree/src/quadtree.rs | Added conditional compilation for the regions() method using #[cfg(feature = "nannou")]. |
| quadtree/Cargo.toml | Configured optional nannou dependency and added a feature flag for it. |
| README.md | Expanded documentation to include new feature details and its benefits for visualization. |
| Cargo.toml (workspace/root) | Added nannou and nannou_egui dependencies at the workspace level. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.