Skip to content

Add nannou feature flag and use in visualisation#16

Merged
alexespencer merged 2 commits into
mainfrom
asp/feature-nannou
Jun 1, 2025
Merged

Add nannou feature flag and use in visualisation#16
alexespencer merged 2 commits into
mainfrom
asp/feature-nannou

Conversation

@alexespencer

Copy link
Copy Markdown
Owner

No description provided.

@alexespencer alexespencer requested a review from Copilot June 1, 2025 17:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new "nannou" feature flag and updates the code to leverage conversions between quadtree regions and nannou rectangles in the visualization module. Key changes include:

  • Refactoring region conversion in visualize/src/model.rs to use Into/From implementations.
  • Updating dependency declarations in Cargo.toml files to support the nannou feature.
  • Adding cfg-based implementations in quadtree/src/region.rs and quadtree/src/quadtree.rs for nannou.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
visualize/src/model.rs Refactored region creation using Into conversion from Rect.
visualize/Cargo.toml Updated quadtree dependency to enable "nannou" feature and adjusted nannou/nannou_egui usage.
quadtree/src/region.rs Added From/Into implementations between Region<2> and nannou::geom::Rect guarded by the nannou feature flag.
quadtree/src/quadtree.rs Added conditional compilation for the regions() method using #[cfg(feature = "nannou")].
quadtree/Cargo.toml Configured optional nannou dependency and added a feature flag for it.
README.md Expanded documentation to include new feature details and its benefits for visualization.
Cargo.toml (workspace/root) Added nannou and nannou_egui dependencies at the workspace level.

Comment thread visualize/Cargo.toml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@alexespencer alexespencer enabled auto-merge (squash) June 1, 2025 17:08
@alexespencer alexespencer merged commit 4167599 into main Jun 1, 2025
1 check passed
@alexespencer alexespencer deleted the asp/feature-nannou branch June 1, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants