Before saying goodbye and stopping, check first whether this skill is currently playing audio.#158
Open
mlopezr wants to merge 1 commit intoalexa-samples:mainlinefrom
Open
Before saying goodbye and stopping, check first whether this skill is currently playing audio.#158mlopezr wants to merge 1 commit intoalexa-samples:mainlinefrom
mlopezr wants to merge 1 commit intoalexa-samples:mainlinefrom
Conversation
… currently playing audio.
|
Hello! I don't understand why this is bad:
I added your code, but now I have problems where I can never stop playing. Is it correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
If users say "Alexa, stop" when AudioPlayer was last used by a custom skill, that skill will receive an AMAZON.StopIntent request, even if audio is not playing any more.
Before giving a goodbye message, a custom skill needs to check whether it is currently playing audio.
Description of changes:
When audio is currently playing,
contextin the intent request looks like:Here's what
contextlooks like if playback is already stopped:I have added checks for StopIntent and PauseIntent for both single-stream and multiple-stream, with unit tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.