Skip to content

Add 'sort' filter to specify results order#57

Open
JackSwingle01 wants to merge 1 commit intoalex9smith:mainfrom
JackSwingle01:main
Open

Add 'sort' filter to specify results order#57
JackSwingle01 wants to merge 1 commit intoalex9smith:mainfrom
JackSwingle01:main

Conversation

@JackSwingle01
Copy link
Copy Markdown

@alex9smith
Copy link
Copy Markdown
Owner

Hey @JackSwingle01 thanks for the PR and sorry it's taken me a while to get to it.

I'm trying to slowly move any validation logic out of the Filters class to stop it being so unwieldy. Are you able to move your new static method to a separate function in validation.py? It'd be great to see some simple tests for it like the validate_tone function has too. You'll also need to rebase onto the latest main.

I'm happy to pick up those changes too if you want to give me write permission to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants