Refactor magstats to fast api#173
Open
mmolina2018 wants to merge 21 commits intomainfrom
Open
Conversation
dirodriguezm
requested changes
Sep 28, 2023
Comment on lines
+25
to
+28
| COPY ./entrypoint.sh /app/ | ||
| COPY ./core /app/core | ||
| COPY ./api /app/api | ||
| COPY ./database /app/database |
Contributor
There was a problem hiding this comment.
El path acá no está correcto
Comment on lines
+31
to
+43
| class TestGetMagstatsSQL(unittest.TestCase): | ||
| def test_db_exception(self): | ||
| def mock_session_factory_with_exception(): | ||
| raise Exception("Test exception") | ||
|
|
||
| with pytest.raises(HTTPException) as exc: | ||
| get_magstats( | ||
| session_factory=mock_session_factory_with_exception, | ||
| oid="oid1", | ||
| handle_error=handle_error, | ||
| ) | ||
|
|
||
| assert exc.value.status_code == 500 |
Contributor
There was a problem hiding this comment.
Por qué poner esto en una clase y los demás tests no ?
Contributor
dirodriguezm
left a comment
dirodriguezm
left a comment
There was a problem hiding this comment.
También veo que falta la parte de CD. Sin eso no tiene mucho sentido aprobar el PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.