chore: bump aleph-cli to 0.10.3#18
Conversation
Bumps the aleph-cli pin from 0.9.2 to 0.10.3. The jump crosses the 0.10.0 boundary, which carried several breaking CLI changes; this adapts the test suite and crn-up.sh to the new surface: - `--ccn-url` global flag renamed to `--ccn` (aleph-rs #176) - `--chain` is now required when signing via ALEPH_PRIVATE_KEY (#168); the testnet uses Anvil/EVM accounts, so `--chain eth` - node/instance create take NAME as a positional arg, not `--name` (#173) - `node create-crn` endpoint flag `--address` renamed to `--url` (#171) Verified each changed invocation against aleph-cli 0.10.3 via --help and --dry-run (local signing, no network).
The first pass missed test_messages.py and test_migration.py (I'd truncated the file enumeration). Same 0.10.0 break: signing via ALEPH_PRIVATE_KEY now requires --chain. Adds --chain eth to post create (×2), message forget, file upload, instance create, and node unlink, plus the now-positional instance name in the migration test.
foxpatch-aleph
left a comment
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This PR correctly bumps the aleph-cli pin from 0.9.2 to 0.10.3, adapting all test code and the crn-up.sh provisioning script to the breaking CLI changes introduced in aleph-rs 0.10.0: --ccn-url -> --ccn, --name becoming positional, --address -> --url, and the new --chain=eth requirement for signing commands. Each invocation was verified against the new CLI's help output, and the diff is minimal and surgical with no unnecessary refactoring. Read-only commands correctly omit --chain. The one nit (test_create_node's check=False pattern) is pre-existing and not a regression.
v0.10.x adds an interactive [y/N] confirmation to destructive commands. Non-interactively, `message forget` reads EOF, prints "Aborted." to stderr, and exits 0 with empty stdout — which broke parse_json with a JSONDecodeError. Pass -y to skip the prompt and submit. (node unlink has no such prompt; the migration test confirms it executes.)
foxpatch-aleph
left a comment
foxpatch-aleph
left a comment
There was a problem hiding this comment.
Correctly handles all breaking changes between aleph-cli 0.9.2 and 0.10.3: the --ccn-url→--ccn rename (widest blast radius affecting every test via conftest.py and three crn-up.sh calls), --chain eth addition on all signing commands, positional name arguments for create subcommands, and --address→--url for CRN creation. The -y flag on message forget handles the new interactive prompt in v0.10.x. All changes are mechanical and well-motivated, with no logic errors, security regressions, or missing adaptations. Read-only commands correctly remain unchanged. The PR is consistent, focused, and correctly adapted to the new CLI surface.
tests/test_messages.py (line 41): The -y flag addition is critical — without it, the CLI's new interactive [y/N] prompt reads EOF in non-interactive mode, exits 0 with empty stdout, and breaks parse_json=True with a JSONDecodeError. Correctly handled here.
tests/conftest.py (line 55): This single line (--ccn-url → --ccn) is the widest blast-radius change — it affects every single test invocation. Correctly renamed.
2 participants
Bumps the
aleph-clipin from 0.9.2 → 0.10.3.The jump crosses the
0.10.0boundary, which carried several breaking CLI changes. Most of the diff adapts the test suite andcrn-up.shto the new command surface.What would have broken
--ccn-urlglobal flag →--ccn(#176)conftest.pycentral fixture (→ every test) +crn-up.sh×3--chainnow required when signing viaALEPH_PRIVATE_KEY(#168)--chain eth(testnet uses Anvil/EVM accounts)nameis positional on create/import (#173)instance create,node create-ccn,node create-crn--name, pass positionally--address→--url(#171)node create-crnincrn-up.shThe
--ccn-urlrename is the widest blast radius — the fixture puts it on every invocation, so the whole suite would fail at argument parsing. The--chainrequirement is the subtle one: the CLI now bails withError: --chain is required when signing with --private-key (or ALEPH_PRIVATE_KEY).Verified unchanged (left alone)
post create/amend/list,aggregate create,message list,file upload/downloadflags,node link --crn, and theitem_hashJSON output are all unchanged. Read-only commands correctly do not get--chain.Verification
aleph-cli 0.10.3via--helpand--dry-run(local signing, no network).bash -n+py_compilepass.