Support additional configs via ONDIRRC environment var#18
Open
sergei-mironov wants to merge 2 commits into
Open
Support additional configs via ONDIRRC environment var#18sergei-mironov wants to merge 2 commits into
sergei-mironov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. I'd like to share some updates I'm working on. The goal is to enable the use of
ondiron a per-project basis. To achieve this, I'm adding support for per-project configurations alongside the existing system-wide and user-wide ones.First, I'm using the ONDIRRC environment variable to load additional configurations. I usually set this variable in each project's
~ projects/whatever/env.sh, which is then sourced by a shell that's local to the project.Second, I want all paths within a per-project configuration to be specified relative to the configuration file itself. So, I've added code that translates
enter ./foldertoenter ~/proj/whatever/folder, where the base directory is the location of the configuration file.Please let me know your thoughts on these changes.