fix: Dockerfile build fails because uv sync runs before source is copied#8
Merged
mjbommar merged 1 commit intoalea-institute:mainfrom Mar 22, 2026
Merged
Conversation
uv sync tries to install the project package (folio-api) which requires the folio_api/ source directory, but it isn't COPY'd until the next step. Additionally, uv venv after uv sync overwrites the venv just created. Split into two steps: --no-install-project for the dependency caching layer, then a second uv sync after the source is copied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv venvafteruv synctries to recreate an already-existing virtual environmentbash -l -cwrapper anduv run pythonno-op--no-install-projectbefore code copy, full sync after) for proper Docker layer cachingCloses #6
Test plan
docker build -f docker/Dockerfile -t folio-api:test .succeedsfolio-api==0.4.0after source copy