Implement running a single benchmark by specifying the line number#59
Open
arjan wants to merge 1 commit intoalco:masterfrom
Open
Implement running a single benchmark by specifying the line number#59arjan wants to merge 1 commit intoalco:masterfrom
arjan wants to merge 1 commit intoalco:masterfrom
Conversation
alco
reviewed
Aug 1, 2017
|
|
||
| # TODO: extract logging from this function and number running tests externally | ||
| defp run_grouped_tests(groups, count, follow, bench_config) do | ||
| count = groups |> Map.values() |> List.flatten() |> Enum.count() |
Owner
There was a problem hiding this comment.
Why does this calculation need to happen here? The function parameter count is no longer used at all.
alco
reviewed
Aug 1, 2017
| end | ||
| end | ||
|
|
||
| defp normalize_files({paths, opts}) do |
Owner
There was a problem hiding this comment.
What if multiple files with line numbers are passed on the command line? In that case, it will explode with a file not found error. We should either support running multiple benchmarks on specific lines or provide a more helpful error message. Up to you.
Owner
|
Thanks for your contribution! I've left a few comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #58