Notice: Undefined property: stdClass::$caption #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New translations default.inc.php (Russian) * New translations default.inc.php (Russian) * New translations default.inc.php (Russian) * New translations default.inc.php (Russian) * New translations default.inc.php (French) * New translations default.inc.php (French) * New translations default.inc.php (Czech) * New translations default.inc.php (Hungarian) * New translations default.inc.php (Spanish) * New translations properties.inc.php (Russian) * New translations default.inc.php (Russian) * New translations properties.inc.php (Italian) * New translations default.inc.php (Italian) * New translations properties.inc.php (Hungarian) * New translations properties.inc.php (German) * New translations properties.inc.php (Czech) * New translations default.inc.php (German) * New translations properties.inc.php (French) * New translations default.inc.php (French) * New translations properties.inc.php (Dutch) * New translations default.inc.php (Dutch) * New translations properties.inc.php (Danish) * New translations default.inc.php (Danish) * New translations properties.inc.php (Spanish)
…instead of darken/lighten/mix
Currently translated at 100.0% (25 of 25 strings) Translation: MODX Extras/System Settings Translate-URL: https://hosted.weblate.org/projects/modx-extras/imageplus/system-settings/nl/
Currently translated at 100.0% (5 of 5 strings) Translation: MODX Extras/Properties Translate-URL: https://hosted.weblate.org/projects/modx-extras/imageplus/properties/da/
* Translated using Weblate (Danish) Currently translated at 100.0% (5 of 5 strings) Translation: MODX Extras/Properties Translate-URL: https://hosted.weblate.org/projects/modx-extras/imageplus/properties/da/ * Translated using Weblate (Italian) Currently translated at 100.0% (5 of 5 strings) Translation: MODX Extras/Properties Translate-URL: https://hosted.weblate.org/projects/modx-extras/imageplus/properties/it/ * Translated using Weblate (Dutch) Currently translated at 100.0% (5 of 5 strings) Translation: MODX Extras/Properties Translate-URL: https://hosted.weblate.org/projects/modx-extras/imageplus/properties/nl/ * Translated using Weblate (Russian) Currently translated at 100.0% (5 of 5 strings) Translation: MODX Extras/Properties Translate-URL: https://hosted.weblate.org/projects/modx-extras/imageplus/properties/ru/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
First of all, thanks for all the work you've put into this extra.
For the first time, I ran into some notices:
Notice: Undefined property: stdClass::$caption in xx/xx/xx/core/cache/includes/elements/modsnippet/18.include.cache.php on line 87
Notice: Undefined property: stdClass::$credits in xx/xx/xx/core/cache/includes/elements/modsnippet/18.include.cache.php on line 88
Notice: Undefined property: stdClass::$altTag in xx/xx/xx/core/components/imageplus/model/cropengines/PhpThumbOf.php on line 157
Notice: Undefined property: stdClass::$caption in xx/xx/xx/core/components/imageplus/model/cropengines/PhpThumbOf.php on line 169
Notice: Undefined property: stdClass::$credits in xx/xx/xx/core/components/imageplus/model/cropengines/PhpThumbOf.php on line 170
In https://github.com/Jako/ImagePlus/blob/master/core/components/imageplus/elements/snippets/imageplus.snippet.php#L87-L88, could it be $data && isset($data->caption)?
It does occur in PHP 7.0, but not in 7.2.
Hope it's helpful.
Ilja