Update daemon.js stockFocus#330
Open
FlashflameVoidspirit wants to merge 2 commits intoalainbryden:mainfrom
Open
Update daemon.js stockFocus#330FlashflameVoidspirit wants to merge 2 commits intoalainbryden:mainfrom
FlashflameVoidspirit wants to merge 2 commits intoalainbryden:mainfrom
Conversation
edit to line 251 to check if in bn8 and removed todo message in line 26
Owner
|
Appreciate the submission. The reason I haven't pulled the trigger on this yet is because someone needs to test whether this actually improves things in BN8, but I'll leave this open as a reminder |
alainbryden
added
the
needs investigation
alainbryden
requested changes
Oct 2, 2024
Owner
alainbryden
left a comment
alainbryden
left a comment
There was a problem hiding this comment.
TODO: Need to do a BN 8.1, 8.2, and 8.3 run on two identical save files - one with, and one without this flag in place, to see if "stockFocus" is optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit to line 251 to check if in bn8 and removed todo message in line 26
saw a todo and fixed it cuz i have time, sorry if this has already been sugested