implemention of #308 hacknet nodes max ram usage #314
Open
samohtGTO wants to merge 4 commits intoalainbryden:mainfrom
Open
implemention of #308 hacknet nodes max ram usage #314samohtGTO wants to merge 4 commits intoalainbryden:mainfrom
samohtGTO wants to merge 4 commits intoalainbryden:mainfrom
Conversation
samohtGTO
changed the title
Owner
|
My only feedback here is that the default should be 1.0 (to default to the current behaviour) - but other than that, it's great to have the extra option to tweak. We may also wish to add something to autopilot which sets this automatically to a lower number it bitnodes where hacking is less important and/or hashes are more important. |
alainbryden
requested changes
Oct 2, 2024
| ['n', false], // Can toggle on using hacknet nodes for extra hacking ram (at the expense of hash production) | ||
| ['use-hacknet-nodes', false], // Same as above (kept for backwards compatibility, but these are now called hacknet-servers) | ||
| ['use-hacknet-servers', false], // Same as above, but the game recently renamed these | ||
| ['hacknet-use-ram-percentage', 0.75], |
Owner
There was a problem hiding this comment.
Suggested change
| ['hacknet-use-ram-percentage', 0.75], | |
| ['hacknet-use-ram-percentage', 1.00], |
| let verbose = false; // "-v" command line arg - Detailed logs about batch scheduling / tuning | ||
| let runOnce = false; // "-o" command line arg - Good for debugging, run the main targettomg loop once then stop | ||
| let useHacknetNodes = false; // "-n" command line arg - Can toggle using hacknet nodes for extra hacking ram | ||
| let hacknetUsePercentage = 0.75 // How much ram percentage ram from the hacknet is getting used. |
Owner
There was a problem hiding this comment.
Suggested change
| let hacknetUsePercentage = 0.75 // How much ram percentage ram from the hacknet is getting used. | |
| let hacknetUsePercentage = 1.00 // How much ram percentage ram from the hacknet is getting used. |
| stockMode = (options.s || options['stock-manipulation'] || options['stock-manipulation-focus']) && !options['disable-stock-manipulation']; | ||
| stockFocus = options['stock-manipulation-focus'] && !options['disable-stock-manipulation']; | ||
| useHacknetNodes = options.n || options['use-hacknet-nodes'] || options['use-hacknet-servers']; | ||
| hacknetUsePercentage = Math.max(options['hacknet-use-ram-percentage']) |
Owner
There was a problem hiding this comment.
Suggested change
| hacknetUsePercentage = Math.max(options['hacknet-use-ram-percentage']) | |
| hacknetUsePercentage = options['hacknet-use-ram-percentage'] |
Not sure why the max was there, it would do nothing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here is the code for my suggestion.